At present, it is necessary to use PHP's auto_prepend_file and auto_append_file to add prepend.php and append.php to each page execution in order to do full page XHProf profiling. I think a hook-based approach would be preferable here, like the one found in the XHProf module. For one, it wouldn't require changes to the web-server config in order to work.

I'm working on this and will submit a patch as soon as I'm sure it's working properly.

Comments

Anonymous’s picture

Anonymous (not verified) commented
Title: Replace prepend.php and append.php with hook-based code for XHProf tests » Add hook-based code for XHProf tests

thanks for the issue.

just to be clear - these methods should exist alongside each other, not in opposition. requiring the hook system means we lose data, but also makes it easier to setup. requiring server config means its harder to setup, but also means we capture more data.