Closed (fixed)
Project:
FullCalendar
Version:
7.x-2.x-dev
Component:
Code
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Reporter:
Created:
3 Feb 2012 at 20:52 UTC
Updated:
20 Feb 2012 at 21:40 UTC
Jump to comment: Most recent file
Currently we're using hook_fullcalendar_options_submit wrong, and it can occasionally break exported views.
In this case, it should be part of hook_fullcalendar_options_pre_view.
| Comment | File | Size | Author |
|---|---|---|---|
| #6 | fullcalendar-1427664-6.patch | 907 bytes | tim.plunkett |
| #1 | fullcalendar-1427664-1.patch | 8.06 KB | tim.plunkett |
Comments
Comment #1
tim.plunkettA large portion of this rewriting was done for #1206742: Contextual filters break Ajax views: Ajax date arguments should be replaced with hidden exposed filters but isn't related to it at all.
Comment #2
aspilicious commentedCan you explain this?
And this?
I didn't test it, but if colorbox still works and the options work than I don't see any problems.
Comment #3
tim.plunkettThe first hunk was running every time, it was supposed to be a way to detect legacy settings but it wasn't working, so I switched it.
The second part isn't needed, because I removed the fullcalendar_process_options() function altogether and moved it's code into fullcalendar_fullcalendar_options_pre_view().
Comment #4
aspilicious commentedSounds good, didn't test it.
Comment #5
tim.plunketthttp://drupalcode.org/project/fullcalendar.git/commit/5480e0b
Comment #6
tim.plunkettHm, I seemed to have missed one thing, that the values hidden with dependency that are blank by default are getting values.
In this case, it's only the custom rewriting fields, so here's a patch that adds back hook_fullcalendar_options_submit for them.
Comment #7
tim.plunketthttp://drupalcode.org/project/fullcalendar.git/commit/96354cd