Partialiy implemented RSS code has gone partially live in Title+Teaser mode
| Project: | Text Link Ads Integration |
| Version: | 5.x-1.0 |
| Component: | Code |
| Category: | bug report |
| Priority: | critical |
| Assigned: | Unassigned |
| Status: | closed |
Jump to:
I'm running drupal 51 with the current version of the textlinkads module. I installed it approx 1 month ago and it started actually serving ads approx 2 weeks ago. I had been serving my RSS feed in full text mode. Today I decided to change my RSS feed to Title+Teaser when I did this and then took a look at the generated feed. I noticed the word Advertisement: inserted after the teaser text. I then tried the title only and full text options to make sure that they were OK. They were, the problem only presented while in Title+teaser mode The link itself wasn't visible since the anchor text was empty I have included the inserted text below. The website 995merchantaccounts.com is the one currently being displayed in my regular textlinkads ad space.
Would love to see the whole RSS feed option go live, but until I can get paid for it. I rather not have this URL inserted in my RSS feed :-)
<p>Advertisement: <a href='http://www.995merchantaccounts.com'></a>
#1
Just verified that the flaw still exists in 1.0
Since there is no official way to disable the output. I have modified the module to ignore the output created for the RSS feed. I'd love to put it back in when the function is complete. Below is the modification I made.
If you don't do this you get the word Advertisement and an empty link included at the end of every RSS entry
<?php
function theme_textlinkads_rss_ad($link) {
$advertisement = variable_get('textlinkads_advertisement_word', t('Advertisement'));
return "";
// PPH Return an empty string to remove the unimplemented text-link-ads function in RSS
//
// Original code below
// $advertisement = variable_get('textlinkads_advertisement_word', t('Advertisement'));
// return "\n\n$advertisement: {$link['rssbeforetext']} <a href='{$link['url']}'>{$link['rsstext']}</a> {$link['rssaftertext']}";
}
?>
#2
Sorry a typo in my above comment. It only shows up in the RSS teaser items. If you aren't using Teaser for RSS you won't see the problem.
#3
I'm just removing this for now with the intention of adding it for real later.
#4
Look forward to its return when complete.
When it does come back, I'd love to be able to activate on select feeds(versus all or nothing). Possibly with diff XML codes for each feed so I could place the text ads by keyword/TAG. Hopefully more finely tuned placement equals more higher paying ads and more money :-)
#5
Automatically closed -- issue fixed for two weeks with no activity.