Allow comment-$type.tpl.php

Simple and straightforward. I see no reason not to just RTBC it.

Just giving my BIG +1 to this one!

Big +1 on the functionality too.

If this gets in, it'll be easier to prepare a patch for flatforum for drupal 6. i.e. bumping :D

Oooh, I like this. +1 from me. :)

Michelle

One question -- does this code get triggered when loading the recent comments block? If so, it would add x node loads to the page view where x is likely to be 10.

This patch looks good, but maybe double-check to see whether that node_load is _really_ needed. It's an expensive call if the only thing you need is the node's type.

No, the recent comments block does not do a theme('comment').

function theme_comment_block() {
  $items = array();
  foreach (comment_get_recent() as $comment) {
    $items[] = l($comment->subject, 'node/'. $comment->nid, NULL, NULL, 'comment-'. $comment->cid) .'<br />'. t('@time ago', array('@time' => format_interval(time() - $comment->timestamp)));
  }
  if ($items) {
    return theme('item_list', $items);
  }
}

I don't think an alternative to node_load is necessary, or a good idea. theme('comment') is only called, in Drupal, when something is known about the node.

nice one. i agree that we are safe for comment block and don't need anything beyond the patch in #1

Personally, I'd be more leaning towards having a solution where both the $comment and the $node object are passed into the various theme functions. Looking at the code, this seems like this might require a bit more work but it will be more elegant/transparent in the end.

Does this look good?

Nice patch!
Reviewing atm...

Sorry, I hitted the Submit button faster than I had planned todo.
This works pretty well, and gives us *a lot* more interesting things to keep in mind when theming!

Code looks also clean and straight forward! Tested on my local copy of head and did some modification to Garland to see if thing work like I expected..

It does, no need to hold this up any longer.. :-)

Committed to CVS HEAD. I'm marking this as 'code needs work' because I don't think it fully implements the original patch's needs.

Thanks for committing it!!

Do you mean the basic styling for forum comments?