I find the current behavior confusing where you click on "overridden" next to a particular component and you are taken to the all components diff page. Since that page supports arguments i'm assuming this is just a bug and it was the intended behavior.

CommentFileSizeAuthor
#1 features-diff_component_link-1428998-1.patch899 bytesjoelcollinsdc

Comments

joelcollinsdc’s picture

joelcollinsdc commented
StatusFileSize
new features-diff_component_link-1428998-1.patch899 bytes
joelcollinsdc’s picture

joelcollinsdc commented

I meant to post yesterday... i have no idea if this is a hack or not. I couldn't figure out why menu_get_item() -> href would drop off the arguments on a menu item. Is that how its supposed to work?

joelcollinsdc’s picture

joelcollinsdc commented
Status: Active » Needs review
matglas86’s picture

matglas86 commented
Status: Needs review » Reviewed & tested by the community

Tested. Great if this is getting in. Helps my reviewing a lot.

mpotter’s picture

mpotter commented

Personally, I don't want to just see a single diff component. I *want* to see all diffs. The better way to handle this is via the issue #1429408: Diff page does not show component titles which organizes the diff output by component name. This allows people interested in a single component to focus attention while still accommodating people who want the entire diff.

Edited: Hmm, well now I see what you are doing. I guess clicking the main "Review Overrides" will still show all diffs which clicking the Override button for a single component should just show that component. So I think I'll agree with this patch. It certainly does what it is supposed to.

mpotter’s picture

mpotter commented
Status: Reviewed & tested by the community » Needs work

Actually, this patch doesn't seem to work for all features. In particular, it doesn't work for the Features Override module (2.x experimental branch). So I need to mark this as still needing work. The #1429408: Diff page does not show component titles patch still works fine though.

tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
commented

@mpotter, what doesn't work outside of overrides?

mpotter’s picture

mpotter commented
Status: Needs work » Fixed

Looks like this is now working fine with the latest versions of Features and Features Override, so committed to ed2bba3.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.