Drupal 7 project

I am the coordinator for the newly formed Media Support Squad (heavily influenced by the successful Views Bug Squad).

This feature module is firstly aimed to members of the squad so that the quickly can setup a new, or start fresh, site to be able to for example work on patches or other issues for the media project.

it is also designed to be useful for anyone else that quickly want to test what the Media module is all about.

The project can be found at:
http://drupal.org/sandbox/tsvenson/1428994
git clone http://git.drupal.org/sandbox/tsvenson/1428994.git mss_media_1

Comments

tsvenson’s picture

tsvenson commented
Title: MSS Media 1 » Media Support Squad

I have renamed the module so that it is possible to create both a 1.x and 2.x branch (to comply with the branch number for the Media project) without any confusion regarding the name or need to have to separate projects.

git clone http://git.drupal.org/sandbox/tsvenson/1428994.git media_support_squad

misc’s picture

misc commented
Status: Needs review » Needs work

Welcome with your application.
I think this is a case for a single project to be promoted instead of getting full access to publish projects.
With that said - I am only missing one thing here, and that is a make file so you easily could download the modules needed, with the correct versions, it's not a 'must', but I think it will make thing easier.

tsvenson’s picture

tsvenson commented

Hi MiSc and thanks for the review.

While a make file would simplify things, I would actually like to avoid that as the target audience is not the general Drupal user. Instead it is for the members of the Media Support Squad who are helping out in the issue queues for the Media and File Entity modules with testing patches and giving support among other things.

There will be needs to mimic a users setup and that would often mean to also make sure we have the same versions of specific modules as the user has.

I'm fine with the single project promotion. Full access would of course be preferred as I have quite a few planned projects based on features that will be hosted on d.o.

misc’s picture

misc commented
Status: Needs work » Reviewed & tested by the community

Okay, I see the point of not having a make file (but I still think you should have a lot to win to have a default setting with modules from the make file, but that's me...).

Feature projects are approved on a per-project basis, more about it here: http://groups.drupal.org/node/186879.

tsvenson’s picture

tsvenson commented

Thanks for the review. Not sure if you saw, but I did commit a couple of changes last night. It now comes with a .install that removes all the manual steps (disable shortcut and toolbar as well as reverting to get the variable override) previously needed.

I've ran it through coder review and got a green light.

I'm also looking into creating a make file. I've got it working, including both cloning the correct 1.x branch of Media as well ass downloading and installing both ckeditor and tinymce. Only thing I am trying to see if it can be solved, before committing it, is if its possible to set the path in the make file so the packages are installed in sites/all without the use of --contrib-destination on the command line. Now it installs in the module folder.

Once that is solved, or deemed impossible, the feature will have a make file as well.

misc’s picture

misc commented
Status: Reviewed & tested by the community » Needs review

Okay, putting it back to need review.

misc’s picture

misc commented
Status: Needs review » Needs work
Issue tags: +PAreview: single application approval

Some stuff:

README.txt
Please take a moment to make your README.txt follow the guidelines for in-project documentation.
Master Branch
It appears you are working in the "master" branch in git. You should really be working in a version specific branch. The most direct documentation on this is Moving from a master branch to a version branch. For additional resources please see the documentation about release naming conventions and creating a branch in git.

With those fixes this should be ok to push out as a single project.

mitchell’s picture

mitchell commented
Title: Media Support Squad » Media Support Squad Feature

Hi, tsvenson!

So, you're submitting projects now, too.. :) Great!

I was on the fence about recommending this feature for approval since #3 describes it mostly as a testing kit for MSS (which is a perfect use case for a sandbox), but it seems to also make sense as a Media Kickstart. What do you think about retitling your project that way?

Regarding the make file, do you plan on making that a separate project? I'm not sure how much it would make sense to have them in the same project. MiSc, what do you think? If you add an issue for #5 to your sandbox, MiSc might be able to offer a review, too.

As an aside, if someone helps coordinate an initiative, is on the Planet, and is a regular contributor in the issue queues, then I'm in favor of rtbc-ing them as a rule. I'll see what others think about this in #drupal-codereview or on gdo/code-review.

K, so I'll leave this as 'needs work' (without fear that we'll end up annoying you) even though the issues so far are minor. I look forward to trying this out when I look closer at Media. Thanks for your contribution!

klausi’s picture

klausi
he/him||they/them
Primary language German
Location 🇦🇹 Vienna
commented
Status: Needs work » Closed (won't fix)

Closing due to lack of activity. Feel free to reopen if you are still working on this application.