Closed (fixed)
Project:
Drupal core
Version:
7.x-dev
Component:
node.module
Priority:
Normal
Category:
Bug report
Assigned:
Unassigned
Issue tags:
Reporter:
Created:
5 Feb 2012 at 21:10 UTC
Updated:
4 Jan 2014 at 01:39 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
sunComment #2
Bojhan commentedCan we also have a msg, that informs the user what happens? I would be befuddled, if I am redirected - and unable to navigate to the page I just created. Something a long the lines of "You created *****, but you do not have sufficient permissions to view the unpublished ***"
Comment #3
gnugetHi.
I created a patch for this issue but i have a doubt, let's suppose to the user not have permissions to view their own content and be redirected to the edit page of that node, so, what happen if the user neither have permissions to edit their own content?, where suppose to be redirected?
I suppose to the user should be redirected to the page where he came from? if the answer is positive just let me know and i will change my patch.
For now i'm sure to my patch still needs work.
Comment #4
jody lynnThis patch redirects users to is they don't have access to the node. That's the same thing that happens when they delete a node.
Comment #6
jody lynnComment #8
jody lynnComment #10
jody lynnComment #11
tim.plunketts/Create/Creates
No real reason for a new langcode variable.
The assertion success message shouldn't use t().
Comment #12
jody lynnI rerolled for the new test file structure.
@tim your first and third comments above aren't consistent with what's being done in the existing tests in NodeCreationTest.php so I didn't make those changes.
Comment #13
jody lynnComment #15
jody lynnCan;t put a constant inside double quotes...
Comment #16
cosmicdreams commentedJust a note to myself and sun. If this patch is committed before #1496542: Convert site information to config system then we'll have to convert this new variable to the new config object.
Otherwise RTBC
Comment #17
sun#15: 1429442-15.patch queued for re-testing.
Comment #19
nrambeck commentedI updated the patch so that the test uses the new config object to set the system front page as mentioned in comment #16
Comment #20
star-szrThanks @nrambeck, looks great.
This comment could be cleaned up a bit:
Set the front page to the default "node" page.
Leaving at needs review.
Comment #21
jody lynnI cleaned up nrambeck's comment and moved the redirect line to the new NodeFormController file.
Comment #22
marcingy commentedComment #23
webchickThis makes a lot of sense. Thanks for the test!
Committed and pushed to 8.x. Marking for D7 backport.
Comment #24
dcam commentedBackported #21 to 7.x.
Comment #25
sun#24: node-form-redirect-1429442-24.patch queued for re-testing.
Comment #27
mathankumarc commentedRe-roll
Comment #28
sunThanks! Only one very minor nit:
Trailing white-space.
After adjusting that, we're RTBC here. :)
Comment #29
mathankumarc commentedRemoved the white space
Comment #30
sunThanks!
Comment #31
David_Rothstein commentedCommitted to 7.x - thanks! http://drupalcode.org/project/drupal.git/commit/5177237
I think there are times where the previous behavior might have been desired (e.g., depends on what you display on your site's access denied page), so I went ahead and mentioned this in CHANGELOG.txt. It's easy enough for someone to override it in their own submit handler if they need to.