I tick the select box next to the field that I would like to display as a pager, the field indeed appears as a pager, but when I re-enter the slideshow settings after I've saved that pager field doesn't appear to be ticked anymore.

Also, when I change the wrapping type the pager field have to be selected again or it doesn't show.

CommentFileSizeAuthor
#4 pager_fields-1429950-4.patch1.21 KBstborchert
#1 pager_field_error-1429950-1.patch764 bytesimclean

Comments

imclean’s picture

imclean commented
Status: Active » Needs review
StatusFileSize
new pager_field_error-1429950-1.patch764 bytes

#default_value for the pager fields was set incorrectly. This should fix it.

fearlsgroove’s picture

fearlsgroove commented
Status: Needs review » Fixed

Thanks, committed
http://drupalcode.org/project/views_slideshow_jcarousel.git/commit/e8c6355

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

stborchert’s picture

stborchert
he/him
Primary language German
commented
Status: Closed (fixed) » Needs review
StatusFileSize
new pager_fields-1429950-4.patch1.21 KB

Unfortunately this isn't really fixed since you forgot to update views_slideshow_jcarousel_views_slideshow_option_definition().

jomarocas’s picture

jomarocas commented
Issue summary: View changes

patch #4 works for me thanks

  • fearlsgroove committed e8c6355 on master 
    Issue #1429950 by imclean: Default value for pager fields set...
netw3rker’s picture

netw3rker commented
Status: Needs review » Closed (fixed)

It looks like both patches are in and now in both master and 7.x-1.x. Thanks everyone!