This is coming out as a result of #1280792: Trigger upgrade path: Node triggers removed when upgrading to 7-dev from 6.25. Based on #69, 6.x -> 7.x upgrade tests need to extend UpgradePathTestCase while 7.0 -> 7.x upgrade tests extend UpdatePathTestCase. The case between 6.x -> 7.x versus 7.0 -> 7.x is particularly severe because implementing the wrong type of TestCase results in a fatal error (related to sessions). This causes a fair bit of confusion in those writing upgrade tests and could be an issue in 8.x as well once it releases unless we can get a better name for the two. @scor had suggested we could possibly have a differentiation by using Major and Minor (so MajorUpgradePathMajorTestCase vs MinorUpgradePathTestCase) - I think such an approach could solve issues. However, I'm not particularly good with names so other suggestions would be welcome.

Comments

tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
commented

Came across this while working on a test for #1211008: Split field_bundle_settings out per bundle.

Thankfully there was already an update.trigger.test or I would have been lost. However, even within that file the term "upgrade" is used. So we should be thorough when making this change.

btmash’s picture

btmash commented
Assigned: Unassigned » btmash

Thanks @tim.plunkett for your thoughts - I'm going to try and make the changes over the course of this week so we have something to review. Also assigning to self.

xjm’s picture

xjm
she/her
Primary language English
commented
Issue summary: View changes
Status: Active » Closed (won't fix)

This is probably a wontfix, since #2134951: Remove upgrade path tests removes one of the two in D8, and we can't change the names in D7 anyway.