Come together with the global Drupal community in Rotterdam, 28 Sept – 1 Oct 2026. Sessions, contribution, connection, and Early Bird savings until 8 June.It's good practice, and can avoid errors from showing, if you check to ensure arrays have data before processing them.
| Comment | File | Size | Author |
|---|---|---|---|
| #1 | subscriptions-n1430484-d6.patch | 4.76 KB | damienmckenna |
Comments
Comment #1
damienmckennaPatch for D6 enclosed.
Comment #2
salvisI agree in principle, but please explain concretely what issues you found and how you're solving them.
D7 first...
Comment #3
damienmckennaI'll work on a D7 patch.
These patches come from my efforts to cleanup a site that was built in 2009 with the 6.x-1.x-dev version of this module from April 19th 2009 and was then heavily hacked by someone who didn't know Drupal. Some of the hacks were for bugs but most were to tailor the module to their specific use cases. This specific patch may be for a bug that no longer exists, but I don't know for certain right yet.
Comment #4
salvisThat's not a good approach. If we cannot identify the problem that we're trying to fix and cannot confirm that we actually did fix it, we're more likely to break something.
Subscriptions is used by a couple thousand of sites and we have a responsibility there.
Comment #5
salvisThis is not committable as-is.