Checking compliance with the w3 standards using http://validator.w3.org returns a few errors such as:

  • There are non standard attributes in spans such as "st_url"
  • There should be quotes wrapping the value of attributes, this is regarding "st_url" again.
  • There's an endtag for span which isn't currently open. This is caused by the above error because the / in http:// is interpreted as the endtag since it's not in quotes.

I propose that the information in the attributes of each span can be put into a javascript variable, this way the markup can be standard complient, and since this module already depends on javascript it wouldn't hinder the performance if the client browser doesn't support javascript.

The array could look somewhat like this.

var shareThis_info =
  {
    st_facebook_large:
      {
        st_url:"http://www.google.com",
        st_title:"Google",
        displaytext:"Facebook"
      },
    etc...
  };

This way you can use the class as the key to quickly get the information of the currently active span via javascript.

Comments

BAM5’s picture

Issue summary: View changes

Apparently is not a supported html special character.

phenaproxima’s picture

I would also like to see this implemented - I'd be happy to roll a patch.

phenaproxima’s picture

Issue summary: View changes

Spell Check

smitty’s picture

Version: 7.x-2.2 » 7.x-2.x-dev
Issue summary: View changes

It would be really great to get ShareThis without those ugly HTML-Errors!

vladimiraus’s picture

Status: Active » Closed (outdated)

Drupal 7 is no loner supported.
Marking as outdated.