Notice: Undefined index: display_field in file_field_widget_value() (line 582 of /module/file/file.field.inc).

Have a look here...

http://drupal.org/node/714350

I had a look there and found nothing useful unfortunately.

That patch already had adapted to the drupal core, as Dries said.

But I'm still experiencing the same error.

You might want to try flushing the cache (again) and then manually deleting the referenced index from your DB.

see http://drupal.org/node/1351506#comment-5428118

I was untangling and indexing error for comment_node_panel (and several other indexing errors)

I worked through this suggestion and it has entirely ended indexing errors on my site..

Let me know...

I am not sure, but this issue might have something in common with http://drupal.org/node/1463860 which I am struggling with.

The attached patch fixes the notice for me.

There might be a better way to do it (enforcing that the setting exists), but this at least allows to get rid of the notice.

I do not like patching the core files.
But seams that sometimes it is just necessary.

Thanks for the patch!

Thanks for the patch !!!

Attaching the patch against 8.x-dev.

Both patches worked.

It would be nice to get some tests for this. Any idea how to trigger the error?

had a problem with undefined index patch #6 worked for me, d7.16

Updated my installation to 7.19 and i got a problem on line 579, and i tried patch from #6, it worked! :-)

I think issue has been hijacked from 8.x to 7.x :(

Yes, this is still needs work for tests for 8.x

#11: use-not-empty-1430934-11.patch queued for re-testing.

The patch #6 works perfectly for me (D 7.22). Thanks! :D

Regarding webchick's question of how to trigger it, the error was showing on a D7.22 site when a user clicked the "add another" twice for a text field, i.e. for a total of three values on one text field. How would that be tested?

Rerolled. Also changed the logic to get rid of the trinary operator and use intval(empty()) instead.

I've marked #2037549: Notice: Undefined index: display_field in file_field_widget_value() (line 587 of */modules/file/file.field.inc) as a duplicate of this issue.

I've had the same issue in D7.26, the patch from #6 fixed it for me.

Here's the D7 version of #21, for anyone who needs it.

Thanks, #23 eliminates the notices in 7.26.

Applied this against HEAD, and it no longer applies.

I'm looking in to rerolling the patch and updating the issue summary.

Rerolled the patch. Uploading for testing.

This bug doesn't appear to exist in D8, or at least I can't reproduce it.

Review carried out:

- Latest dev of D8 (clean install)
- Added a field of type "Text (plain)" to the article content type and set values to "unlimited".
- Add node of type article. There are 3 textfields showing initially.
- Added text to all 3 textfields. Added another textfield with some dummy text. Added a fifth textfield with dummy text and saved the node.
- No error messages.

I then applied the patch in #28 and carried out the above steps - also no errors.

@littledynamo looking at the code and issue summary this appears to be a file field issue - can someone confirm that we still have the issue in 8.0.x? Thanks.

Agree with @littledynamo I can't reproduce this issue.
And:

To Reproduce the issue:
When a user clicked the "add another" twice for a text field, i.e. for a total of three values on one text field, this error would display.

Is impossible clicked the "add another" twice for a text field, because the button become disable until the next text field is add.

I also suggest that we should change status of issue to "cannot reproduce". I've tried to reproduce it under D8 and D7 without any success.

FWIW it seems that was only ever an issue on D7 and that patches in this thread fixed it. However those patches were never committed to D7 and closing the ticket since the problem doesn't/never did appear in D8 would seem to leave D7 w/o a fix.

We encounter this notice in our logs now with the latest version of Drupal 7.32.

Patch for D7.

Patch from #39 worked like a charm. Thanks!

FYI the patch in #39 is identical to the one from #23.

When will this patch be released from dev? Unfortunately I cannot patch our core as I don't have admin privileges. We are running the latest core, 7.38. I'm getting this error on a regular file field.

@monaw: This will be committed once it gets to RTBC and one of the core maintainers commits it. To help it on its way you could try doing a local test of the patch and provide a review, even if you're not able to run it on a production site.

@DamienMcKenna: thanks you for your reply! I look forward to the release.

Unfortunately I don't have time to setup a local test of the patch and provide a review, I'm very sorry. I have a crazy deadline coming up and my boss will give me a lot of grief for taking "his" time to do that as we have a rather complicated system and it will take quite awhile to setup a local replicate. Actually the system I'm working on is our "dev" and still I don't have the privilege to patch core. It is very unlikely that the sysadmin will patch core as the copy of Drupal is shared among many other sites at our organization.

I think #23 / #39 miss to invert the return of empty().
We want $input['display'] = intval(!empty($field['settings']['display_field']));.
We had that already in #6.

Ok, I figured out the solution without having to hack core (because I don't have permission to do so)…

The problem was caused by a hidden image field. When I changed the image field to not hidden in the content type settings, then the error went away. But for our application, we don't want to show that field so in my custom module, I set the field's #access to FALSE:

$form['field_is_poster']['#access'] = FALSE;

and that worked…field is not shown and there is no error (:

By the way, I'm using Drupal 7.38.

Hope this helps someone else!

@monaw It would be great if you could please provide a review. That is how the issues move toward completion. Is the critique in #45 from @das-peter valid? If so, provide a new patch with the change instead.

Could not replicate.

This error not only appears for textfield with multiple values. In my case, I have a Price Table field (from commerce_price_table) with unlimited values and when I click "Add another" more than twice, this error starts appearing.

This has been tested in 7.x-dev and the errors disappear. This is simply patch #39 with das-peter's correction in comment #45.

I am getting this error when programatically submitting and validating node edit form. e.g.

A form callback with:
field_attach_form($entity_type, $entity, $form, $form_state);

$form = drupal_build_form('form_callback', $form_state);
drupal_form_submit('form_callback', $form_state);
drupal_validate_form($form['#id'], $form, $form_state);

The patches in #49 fixes the issue.

If I get some time I will write a test.

The patch in #49 would introduce a bug similar to #2593377: "Include file in display" has no effect with media browser widget fields where the display setting would have no effect.

Here's an alternative patch - I haven't been able to reproduce the original issue, though.

I believe I have tracked down the cause of the issue.
It seems to be related to image fields, which piggyback on many of the file field functions.
The thing is, in `image_field_info` there is no `'display_field' => 0,` in the settings array, where in `file_field_info` there is.
Now because the image field uses `file_field_widget_settings_form`, which expects `display_field` to be set, we get this notice error.

The patch in #49 is the correct fix for this issue.

I think that this still needs more review - as I mentioned in #51, applying the patch from #49 would introduce the following bug:

Steps to reproduce

1. Add a File field to a content type, using the "File" widget, and enable the Display field
2. Create a node with a file in that field, and uncheck "Include file in display"

Expected result

The file is not displayed (to admins or anonymous users)

Actual result

The file is displayed.

Hey @malcomio

Sorry, I have tested #49 and you are right, it ignores the "Include file in display" checkbox.
I then tested your patch in #51 and confirm it works.

I have updated the issue summmary with steps to reproduce.

Patch from #39 worked for me! Thanks

Can someone provide a review? That is a required step to get this bug fixed in Drupal core.

I had this issue happen on a clean install. #51 fixed the issue for me. :)

I did a extensive research on this.
Started with image module where I set the default 'display_field' value. Also tried to add 'display_field' => 0 into $form 'my_image_file_field' where it is expected so it's there before the render kicks in and still the error persisted.

If we look at the original lines in file.field.inc file:

if (empty($input['display'])) {
  $input['display'] = $field['settings']['display_field'] ? 0 : 1;
}

By my means this is bad coding. PHP is quite strict about undefined array indexes and if there's a slight chance 'display_field' is not set, this line will produce a notice.

The outcome of my review is, even if there's an alternative solution to this issue, this line in the if statement should be replaced with:

$input['display'] = !empty($field['settings']['display_field']) ? 0 : 1;

In this case, file module doesn't rely that 'display_field' is set. Using empty() function in deep arrays with dynamic indexes makes our lives better.
I suggest we accept the patch in #51 as a confirmed solution.

Bump.
Can this issue get some D7 core contributors attention?

#51 Appears to work for the case I was having.

Straightforward, marking for commit and very probable inclusion in 7.50.

While the patch is certainly harmless, I think we should be careful with these because hiding a PHP notice sometimes hides an actual bug with deeper consequences...

Bottom line, reading through the issue the root cause of the problem is not clear.

Naively, it should not be a problem at all:

• file_field_widget_process() sets $element['display'] as a hidden form element with value = 1 whenever the display field is not present in the field settings (e.g. for image fields).
• Therefore, when that field is submitted, file_field_widget_value() should always have $input['display'] equal to 1 also, so the error should never occur.

The steps to reproduce in the issue summary do work, but require doing this:

drupal_build_form('my_test_form', $form_state);
drupal_form_submit('my_test_form', $form_state);

If you call drupal_build_form() first, that is going to put all sorts of things in $form_state['values'] that aren't normally there. I don't think it's a documented or supported way to call drupal_form_submit()... normally you would just build $form_state['values'] manually with the values you're actually trying to submit. If you do that I don't think this bug occurs.

The duplicate issue at #2037549: Notice: Undefined index: display_field in file_field_widget_value() (line 587 of */modules/file/file.field.inc) mentions something with the Field Collection module as a way to reproduce, but I wasn't able to figure it out.

So does anyone understand a way to reproduce the problem in the real world? If there is one and it's not due to other code doing something else wrong, I'd be in favor of this issue.

Also, this issue originally got the "Needs tests" tag in #13 but it's not clear why it was later removed. There are no automated tests in the patch, and automated tests would help (among other things) figure out if it's an issue in Drupal 8 also. People said above they couldn't reproduce it in Drupal 8, but I'm not sure any of those same people could reproduce it in Drupal 7 either! The code is very similar in Drupal 8 so I'm not really convinced this is actually a Drupal 7-only bug, if it's a bug at all.

#51 works for me with File field path and File resup

Why not publishing this patch with the next update ?

@Aporie because it requires tests. Mentioned in #64.

Worked for me. Tx!

Patch #51 does the job for me as well.

Bumping to 7.61, this didn't make it into 7.60

Patch #51 worked for me. I encountered the error on uploading an image on the edit form of a node, on Drupal 7.61.
Reading around, the error seems to occur for images as they have no display_field according to https://www.drupal.org/project/drupal/issues/714350 #2 and #9.
The patch that checks the presence of the display_field prior to calling it, appears sensible.

I have decided to commit this without Tests as hardening of the code instead of a bug report:

- Several people had been able to reproduce it using contrib modules (there is an impact)

- Core itself ran into this problem in Drupal 7.9 and fixed it for the image formatter specifically -> This means every other (contrib) implementation would need to fix it again and again, which is a "red flag" in itself

- If something is empty, it's okay to assume that it's meant to be 0

While there could be bugs hidden by hiding the notice, the probability that they would like that to show is very unlikely (and would be noticed in manual testing) and behavior for already broken code does not change

Therefore => Committing

Only need to check if Drupal 8 needs something similar to harden first

Okay, in Drupal 8 the code is the same:

      // Checkboxes lose their value when empty.
      // If the display field is present make sure its unchecked value is saved.
      if (empty($input['display'])) {
        $input['display'] = $element['#display_field'] ? 0 : 1;
      }

However in this case $element['#display_field'] is always set as code before that adds it extra:

      $field_settings = $this->getFieldSettings() + ['display_field' => NULL];
      $elements['#display_field'] = (bool) $field_settings['display_field'];

But because we never use $field['settings'] again in D7 at that point, the fix is good to go as is, e.g. there is no win for us to add the 'display_field' => NULL to the settings over the fix here.

=> Ready to be Committed

Committed and pushed to 7.x! Thanks all!

Thanks !

Stops working with core version 7.69. Updating patch to be applicable for latest core.

Isn't that going to return the same value in integer for both cases?

  $input['display'] = !empty($field['settings']['display_field']) ? 0 : 1;
  $input['display'] = intval(empty($field['settings']['display_field']));