This issue is a very simple part of the family of issues being opened after discussion in #1222106: Unify language negotiation APIs, declutter terminology. Given we are moving the language negotiation code to language module, we are preparing the code for being in that namespace. This patch does a simple search and replace to change the built-in negotiation constants from LOCALE_LANGUAGE_NEGOTIATION_* to LANGUAGE_NEGOTIATION_*.

Only the names of the constants are changed, no other change is included.

CommentFileSizeAuthor
locale-language-negotiation-to-language-negotiation-0.patch19.43 KBgábor hojtsy

Comments

plach’s picture

plach
he/him
Primary language Italian
Location Venezia
commented
Status: Needs review » Reviewed & tested by the community

The patch looks ok. Will we change the constant values while moving the Language negotiation API into the Language module?

gábor hojtsy’s picture

gábor hojtsy
he/him
Primary language Hungarian
Location Hungary
commented

Yes, I expect so. That will be a much smaller patch though, less possibilities for conflict.

plach’s picture

plach
he/him
Primary language Italian
Location Venezia
commented

Makes sense, I guess we could also #1222194: Rename global $language to $language_interface meanwhile.

dries’s picture

dries commented
Status: Reviewed & tested by the community » Fixed

This looks like a very logical cleanup. Committed to 8.x. Thanks!

gábor hojtsy’s picture

gábor hojtsy
he/him
Primary language Hungarian
Location Hungary
commented
Issue tags: -sprint

Yay, thanks, quick change notification node submitted too: http://drupal.org/node/1432876

Automatically closed -- issue fixed for 2 weeks with no activity.