Closed (fixed)
Project:
Chameleon
Version:
7.x-1.x-dev
Component:
Code
Priority:
Normal
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
11 May 2007 at 02:28 UTC
Updated:
24 Jun 2011 at 07:31 UTC
Jump to comment: Most recent file
Comments
Comment #1
jrabeemer commentedYou have to make sure the permissions for this module are enabled. There is a view permission which determines which role can see the menu.
Comment #2
sillygwailoNo, SimpleMenu doesn't actually display in Chameleon. This is with the #1 user, so it has permissions to see SimpleMenu.
Comment #3
m3avrck commenteddoes this still apply with the new 5.0 version?
Comment #4
sillygwailoThe (very quick) test that I did shows that SimpeMenu still doesn't display in Chameleon. Is it because Chameleon is not a PHPTemplate theme?
Comment #5
motin commentedThe solution _is_ a one-liner:
Add these lines just above "$output = "
// Needed for chameleon theme to include SimpleMenu js+css
$variables = array(
'closure' => theme('closure'),
);
Cheers,
Fredrik
Comment #6
motin commentedThe solution is more or less a one-liner:
Add these lines:
just above:
in chameleon.theme (= just above Line 39).
Cheers,
Fredrik
Comment #7
m3avrck commentedSeems like that is an issue with the chameleon theme and should be an issue for core...
Comment #8
ainigma32 commentedOn line 118 of chameleon.theme the closure is called:
The problem is that hook_footer of simple_menu is adding css through drupal_add_css and that chameleon already called drupal_get_css on line 48 so the added css is never included in the page.
Using motin's fix theme_closure (and effectively) hook_footer is called twice; once before outputting the header and once on line 118 as mentioned above.
To use motin's fix and prevent hook_footer from being called twice we could call theme_closure before outputting the header and catch the returned values (if any).
Then we output the page and finally we output the result of theme_closure before we close the body tag.
I've attached a patch for testing and discussion.
- Arie
Comment #9
ainigma32 commentedNo reviews yet. Setting this to bug report to get some attention. Arguably it is a bug.
- Arie
Comment #10
ainigma32 commentedBumping this issue one last time.
- Arie
Comment #11
ainigma32 commentedJudging from the overwhelming attention it looks like this patch is not 'popular' enough to be tested or applied.
- Arie
Comment #12
mr.baileysI agree with you that this can be called a bug, so I'd leave it as CNR until someone finally decides to review it, even though it's not popular. Chameleon is currently broken (#374650: Chameleon broken by hook_page_alter), so this patch will probably have to be re-rolled after that has been resolved.
I wouldn't mind applying/testing/reviewing this patch after that one has landed...
Comment #13
mr.baileysChameleon has been moved from core to contrib, changing queue.
#374650: Chameleon broken by hook_page_alter
#315533: Remove all themes but Garland and Stark from core
Comment #14
ainigma32 commentedOK rerolled for chameleon contributed theme.
- Arie
Comment #15
johnalbinFixed when converted to phptemplate theme.