Closed (fixed)
Project:
Field Slideshow
Version:
7.x-1.x-dev
Component:
User interface
Priority:
Normal
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
7 Feb 2012 at 13:35 UTC
Updated:
22 Mar 2012 at 15:50 UTC
Jump to comment: Most recent file
Comments
Comment #1
davisbenHere's a patch that will check if any field is using a carousel pager, and only run the requirement check if it is in use.
Comment #2
mrfelton commentedWorks for me. Thanks.
Comment #3
gaele commentedThanks.
Comment #4
steven jones commentedThanks for the patch 10oclock, but querying the database directly for this information is just the wrong way to go, instead we should be using the Field info API, probably field_info_instances.
Comment #5
davisbenThanks for the pointer. Here's an updated patch using field_info_instances.
Comment #6
steven jones commentedAwesome work! Looking good except for one thing:
You can apply a field slideshow to any entity, not just a node, so this needs another foreach in here, so it looks something like:
Comment #7
davisbenPatch updated to reflect the comments in #6.
Comment #8
steven jones commentedGreat stuff, this patch is good to go!
Comment #9
jdanthinne commentedThanks guys! Commited and pushed to DEV.