Select Field not filled with Theme Names

it was made for 4.5 and has not been adjusted to work with HEAD yet.

But the patch does not apply.

your patch does not apply, I tried it, and that has little to do with bieng HEAD or 4.5, since HEAD msections.module == 4.5 sections.module.

I think you are usting the wrong line endings. please use unix endings only, as is required in Drupal coding guidelines.

Bèr

indeed. I meant that this (and previous sections patches) cannot be applied. my pathcing system gets errors.
the drupal handbook has good sections on Diff and PATCH.

Here's a better patch to make sections.module work with 4.6. It uses list_themes rather than system_theme_data. This has the advantage of not requiring Drupal to load each and every theme for every page on which _sections_theme_select is called. This also removes the requirement that the ability to switch to a theme be enabled for users before it is presented in the sections UI. This restricting is not ideal, as it prevents admins from creating sections with special themes that are not for normal use.

This patch also removes the _init hook, which is no longer necessary due to a recent improvement to the theme system. It is better to use the _menu hook, as it is called only for non-cached page views. This also fixes a bug in which the ability for users to switch themes using their "my account" page was defeated by this module.

unfortunately, the sections.module as downloadable from cvs still contains the old code from december 2004. after some time of fiddling around with the code i arrived at the shortname/name mod by myself
(i was not aware of this thread).

replacing shortname by name in _sections_theme_select
basically works in my setup [multihost (multiple aliases to two drupal instances using single database with prefixed table names), and drupal residing in subdirectory].

In addition i will also try the 2nd more elaborate patch given here ASAP.

So Ber, would You please update Your CVS in order to make the sections.module usable.

And publish it officially for 4.5 as well as for 4.6.x (with one of the two patches applied), the module is great as it is!

And no one will prevent You/us to apply better ideas in the future.

Best regards,

Michael

patch < sections.module sections-46-update.patch
patch unexpectedly ends in middle of line
patch: **** Only garbage was found in the patch input.
[chuees-Computer:drupal/modules/sections] chuee%

changing shortname to name works fine for me as well.

Ber, I have a CVS account, if you are to busy to deal with this, I would be willing to take over (for the short term), to get it working in 4.6 and 4.5.

I am no 'hot shot' coder, but I think there are plenty in the community who would be willing to lend a hand. *looks through thread at many contributed patches*.

Just a thought. The offer is always there.

solon, could you please first contribute your patch? then I can have an idea awhat you are up to ;). Not that I dont trust you, the fact you ask beforehand is a very good sign, but I have had bad experiences with people seriously breaking my modules without even asking me anything.
Hence I would like to see what your plans are :)

the patch posted at top (and reposted below) worked for me with Drupal 4.60 installed in a subdirectory using a fantastico script

I agree that this module seems to work as well or better than most that are posted as 4.6 ready and I think it's a crucial one for a site to develop visual variety. Ifit were promoted for general use I think more folks would chime in and debug it.

Thanks for creating it.
jessz

Index: sections.module
===================================================================
RCS file: /cvs/drupal-contrib/contributions/modules/sections/sections.module,v
retrieving revision 1.1
diff -u -F^f -r1.1 sections.module
--- sections.module 15 Nov 2004 19:32:13 -0000 1.1
+++ sections.module 14 Dec 2004 01:42:36 -0000
@@ -211,7 +211,7 @@ function _sections_theme_select() {

foreach ($themes as $key => $info) {
if($info->status) {
- $options[$key] = $info->shortname;
+ $options[$key] = $info->name;
}
}
return $options;

fixed in HEAD, thanks for the patch!