Provide visual feedback that drush make is doing something

Agreed, this would be useful. Here's a start.

We usually use drush_log() with type='ok' for this. Also, lets not emit anything for validation unless that really takes a while.

The main delay before you get any output at all is the validation step. We could skip the 2nd message entirely perhaps, since once validation completes, you usually get feedback pretty quickly. Unless of course your .make file says to get core via git in which case it usually takes another long time before you see any progress. So, I'd actually just recommend keeping both messages (or something better worded if you prefer).

That said, duly noted on drush_log(). I'll re-roll.

Thanks,
-Derek

Unless I'm mistaken, validation only takes a long time with the --drupal-org option set. Drush make on its own doesn't really do any time consuming validation. I'd vote for putting the validation log message into drupalorg_drush.

And here's a patch for drush make itself to log something before calling make_projects(). I still think it's useful to log something then, too, since cloning from Git can often take quite a while and it's nice to let people know something's happening.

Rerolled #6 for latest master. Any objections?

Once that's in, we can worry about trying to patch drush itself.

With a little more local testing, pushed a modified version of #8 to drupalorg_drush:

http://drupalcode.org/project/drupalorg_drush.git/commit/0995a6f

Moving this back to the drush queue for fixing drush make itself via #7 (which still applies cleanly at the end of the 7.x-5.x branch and still works):

%  drush --include=/.../drupalorg_drush/tests/.. --nocolor make /.../drupalorg_drush/tests/makefiles/do-succeed.make --test --md5=print --drupal-org --drupal-org-whitelist-url=file:///.../drupalorg_drush/tests/packaging_whitelist_data
Starting Drupal.org contrib makefile validation, please wait                [ok]
Beginning to build                                                          [ok]
/Users/wright/.drush/drupalorg_drush/tests/makefiles/do-succeed.make.
update_test_module-7.x-2.2 downloaded.                                      [ok]
update_test_module patched with                                             [ok]
1404774-drupalorg_drush_test_pass_patch.patch.
Generated PATCHES.txt file for update_test_module                           [ok]
776b929663eafddeb58240202dc7308a

This patch is giving us this part:

Beginning to build                                                          [ok]
/.../drupalorg_drush/tests/makefiles/do-succeed.make.

#7 looks good. We need a reroll for 8.x

Ask and ye shall receive! ;)

I hadn't done a pull, so that patch has some fuzz. Here's a re-roll without fuzz.

Committed to 6 and 5.

Thanks!