There was getting to be a lot of parameters going to the apps_profile_install_tasks function so instead I've changed it to being an array of server settings.

I've updated all the code and docs to reflect this.

Also note: The default content option has been changed to a function callback instead of having openenterprise specific settings in there. I wanted a callback because we want the ability to choose different bundles of content to install which this would allow to do.

CommentFileSizeAuthor
#6 1431992-update-install-profile-def-031212-reroll.patch5.41 KBpopulist
#4 1431992-update-install-profile-def-031212.patch5.81 KBpopulist
#1 1431992-update-install-profile-def.patch5.32 KBrandallknutson

Comments

randallknutson’s picture

randallknutson commented
StatusFileSize
new 1431992-update-install-profile-def.patch5.32 KB

Attaching patch.

randallknutson’s picture

randallknutson commented
Status: Active » Needs review
febbraro’s picture

febbraro commented
Status: Needs review » Needs work 
+++ b/apps.profile.incundefined
@@ -268,6 +268,14 @@ function apps_profile_install_app_modules(&$install_state) {
+  if ($_SESSION['apps_default_content']) {
+    $function = $_SESSION['apps_server']['default content callback'];

The if test should be on $_SESSION['apps_server']['default content callback'] as well, no?

populist’s picture

populist commented
Status: Needs work » Needs review
StatusFileSize
new 1431992-update-install-profile-def-031212.patch5.81 KB

Here is an updated patch that applies against the latest -dev release and does a check for $_SESSION['apps_server']['default content callback'] as well.

febbraro’s picture

febbraro commented
Status: Needs review » Needs work

Your patch is from the drupal root, not relative to the apps module root folder. Can you give a quick reroll? My dev setup does not have the same path as your patch.

populist’s picture

populist commented
Status: Needs work » Needs review
StatusFileSize
new 1431992-update-install-profile-def-031212-reroll.patch5.41 KB

Sure - rerolled.

febbraro’s picture

febbraro commented
Status: Needs review » Fixed

Many thanks fellas.

http://drupalcode.org/project/apps.git/commit/1403610

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.