Closed (fixed)
Project:
IE 6 Update
Version:
6.x-1.3
Component:
Code
Priority:
Normal
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
8 Feb 2012 at 01:01 UTC
Updated:
22 Feb 2012 at 20:30 UTC
This module needs to implement hook_uninstal() to properly delete the variables it sets via the admin page. Otherwise, disabling and deleting the module leaves some cruft in the DB.
While we're adding a new install file, we may as well implement hook_insall().
Here are the contents of the install file as the attachment feature of the site disallows files with a ".install" extension:
/**
* @file
* Handles ie6update installation and upgrade tasks.
*/
/**
* Implementation of hook_install().
*/
function ie6update_install() {
variable_set('ie6update_destination_url', 'http://www.microsoft.com/windows/internet-explorer/default.aspx');
variable_set('ie6update_update_bar_message', 'Internet Explorer is missing updates required to view this site. Click here to update... '),
}
/**
* Implementation of hook_uninstall().
*/
function ie6update_uninstall() {
variable_del('ie6update_destination_url');
variable_del('ie6update_update_bar_message');
}
(Obviously the closing "?>" need not be included.
Comments
Comment #1
mvcmakes sense to me.
iamEAP: you can create a .patch file which includes new files; see http://drupal.org/patch
Comment #2
iamEAP commentedCommitted and released in 6.x-1.4.
Also, thanks for the tip mvc.