Every. Single. Make file. that I've looked at does git clones like this:

projects[mongodrop][type] = profile
projects[mongodrop][download][type] = git
projects[mongodrop][download][url] = http://git.drupal.org/project/mongodrop.git

As a result, Every. Single. Distribution. Author. is going to have to create and commit a patch like http://drupalcode.org/project/nodestream.git/patch/287a07793a0159106680b... to their distro.

It's perfectly safe to git clone from Drupal.org, so we should allow this property.

CommentFileSizeAuthor
#3 1432290-3.allow-git.d.o-url.patch1.88 KBdww
#2 1432290-2.allow-git.d.o-url.patch1.89 KBdww

Comments

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
commented
Category: feature » task

Moving to a task from a feature request. This is a major DX headache because drush generate-makefile files will fail every time.

dww’s picture

dww
we/he/they
commented
Assigned: Unassigned » dww
Status: Active » Needs review
StatusFileSize
new 1432290-2.allow-git.d.o-url.patch1.89 KB
dww’s picture

dww
we/he/they
commented
StatusFileSize
new 1432290-3.allow-git.d.o-url.patch1.88 KB

Wrong variable for the project name in that error message. Try this instead.

dww’s picture

dww
we/he/they
commented
Status: Needs review » Fixed

Committed, pushed, and deployed on both util and www1.

dww’s picture

dww
we/he/they
commented

Tee hee, needed to fix one of the tests, too:
http://drupal.org/commitlog/commit/31076/11219338448697d2c662d673d7e8f27...

Automatically closed -- issue fixed for 2 weeks with no activity.