The service links module does not call the translation function - t() - around the text & title attribute of the service links (when rendered).
i.e.

Line 588: $service['attributes']['title'] = $service['description'];
.
.
.
Line 619: 'text' => $service['name'],

I've created a patch to fix it (attached).

CommentFileSizeAuthor
#2 service_links-1432536-2-translations.patch1.08 KBsimon georges
service_links_t_functions.patch950 byteseyal shalev

Comments

goz’s picture

goz commented
Status: Active » Needs review

I have same issue and patch works for me

simon georges’s picture

simon georges commented
Version: 7.x-2.1 » 7.x-2.x-dev
Priority: Major » Normal
StatusFileSize
new service_links-1432536-2-translations.patch1.08 KB

Proper patch on 2.x-dev.
All credit goes to Eyal Shalev.

simon georges’s picture

simon georges commented

I understand the need for the translated description, but is there a reason to translate the name? Don't all the services have the same name in all languages?

goz’s picture

goz commented

The service link on display use this name. So for example, "Share on Facebook" could be translated. Or "Bookmarks" or other service (and custom services)

simon georges’s picture

simon georges commented
Version: 7.x-2.x-dev » 6.x-2.x-dev
Status: Needs review » Patch (to be ported)

Committed in 7.x-2.x. Thanks!
Moving to 6.x-2.x.

TheCrow’s picture

TheCrow commented
Status: Patch (to be ported) » Fixed

Backported some commit ago

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.