Provide a way to have exposed filters on block

After having a conversation with Dereine and solving some doubts on IRC, I'll try to create a 2 patches:

Patch 1 - Small and good enough to go in: it simply removes the limitation and uses the current URL as the path for the exposed block. It also presents a warning checkbox.

Patch 2 - Allows the user to set the path of the display INSIDE the display's "Exposed form options", for any kind of display.

Here is patch 1. Needs tests.

If it works, I will clean it a little more and create Patch 2.

Opera and d.o file uploads don't like each other...

Absolutely.

Like this?

        if ($this->has_path()) {
         $form['exposed_block'] = $exposed_form_with_path;
        }
        else {
          $form['exposed_block'] = $exposed_form_without_path; 
        }

Or would you prefer it like this?

        if ($this->has_path()) {
          $form['exposed_block'] = array(
            '#type' => 'radios',
            '#options' => array(1 => t('Yes'), 0 => t('No')),
            '#default_value' => $this->get_option('exposed_block') ? 1 : 0,
          );
        }
        else {
          $form['exposed_block'] = array(
            '#type' => 'checkbox',
            '#title' => 'Yes, <strong>I understand that this display doesn\'t have a path</strong>, and the exposed filters will not work as expected',
            '#description' => 'This display doesn\'t have a working path. It does not work as most people would expect. Mark this option if you have a use for it anyway.',
            '#default_value' => $this->get_option('exposed_block') ? 1 : 0,
          );
        }

Revised patch.

+++ b/views.module
@@ -1917,8 +1917,9 @@ function views_exposed_form($form, &$form_state) {
+  //dpm($view->get_url());

Remove this.

Also remember to change the status to 'Needs Review' every time you post a new patch.

dagmar, thanks for remembering.

I had the intention to remove this after someone tested it. But I will do so now.

Here it goes. Simply removed the dpm() line.

+++ b/views.module
@@ -1603,7 +1603,6 @@ function views_debug($message, $placeholders = array()) {
-      dpm($output);

Mmm. This shouldn't be removed. This dpm is part of the view_debug function.

+++ b/plugins/views_plugin_display.inc
@@ -2012,11 +2010,21 @@ class views_plugin_display extends views_plugin {
+          $form['exposed_block'] = array(
+            '#type' => 'checkbox',
+            '#title' => 'Yes, <strong>I understand that this display doesn\'t have a path</strong>, and the exposed filters will not work as expected',
+            '#description' => 'This display doesn\'t have a working path. It does not work as most people would expect. Mark this option if you have a use for it anyway.',
+            '#default_value' => $this->get_option('exposed_block') ? 1 : 0,

Also, the strings used in '#title' => and '#description' => cannot be translated at this momment. Wrap the strings using the t() function.

dagmar, I only did that so it doesn't add "to-be-changed" strings on people's database.

I suppose that people messing with patches should expect that, hehee. sorry.

dereine, you're right.

I want to leave room for a feature where a user may force and set the block path IF $this->get_option('exposed_block') == 1
Would something like this work?

  /**
   * In some occasions, a block display may want a path.
   */
  function get_path() {
    if (empty($this->options['path'])) {
      return current_path();
    }
    else {
      return $this->get_option('path');
    }
  }

How about this, on views_plugin_exposed_form.inc:

  /**
   * Render the exposed filter form.
   *
   * This actually does more than that; because it's using FAPI, the form will
   * also assign data to the appropriate handlers for use in building the
   * query.
   */
  function render_exposed_form($block = FALSE) {
    // Deal with any exposed filters we may have, before building.
    $form_state = array(
      'view' => &$this->view,
      'display' => &$this->display,
      'method' => 'get',
      'rerender' => TRUE,
      'no_redirect' => TRUE,
      'always_process' => TRUE,
    );

    // Some types of displays (eg. attachments) may wish to use the exposed
    // filters of their parent displays instead of showing an additional
    // exposed filter form for the attachment as well as that for the parent.
    if (!$this->view->display_handler->displays_exposed() || (!$block && $this->view->display_handler->get_option('exposed_block'))) {
      unset($form_state['rerender']);
    }

    if (!empty($this->ajax)) {
      $form_state['ajax'] = TRUE;
    }
    
    // The exposed form always needs an action URL.
    if (!empty($view->override_url)){
      $form['#action'] = $view->override_url;
    }
    elseif (!empty($display->display_options['path'])) {
      $form['#action'] = $display->display_options['path'];
    }
    elseif ($view->get_url()) {
      $form['#action'] = $view->get_url();
    }
    else {
      $form['#action'] = current_path();
    }
    
    $form_state['exposed_form_plugin'] = $this;
    $form = drupal_build_form('views_exposed_form', $form_state);
    $output = drupal_render($form);

    if (!$this->view->display_handler->displays_exposed() || (!$block && $this->view->display_handler->get_option('exposed_block'))) {
      return "";
    }
    else {
      return $output;
    }
  }

In the meanwhile, can we get a warning telling users that their settings (exposed forms on view blocks with ajax disabled) will not result in the expected behavior? Because this is a recurring issue, we should try to mitigate it while we fix it.

Of course, I'm all for fixing it.

A warning would be very helpful

To add exposed form in block follow these step:

1)First add view in page
2)Then add required fields and filters as per your requirements
3)Under Advanced section Look at Exposed Form and set the link to Yes while clicking on Exposed form in block: option and save it.
4)Now goto admin/structure/blocks and see your newly created exposed form block listed under Disable blocks region. Now You can configure it and show on desired page.

FYI the "assigned" field is for indicating that you're actively working on an issue, if you're not actively working on an issue please leave it set to "unassigned". Thank you.