...coming from #1182058-34: Add Entity Translation (entity_translation) support for menu items using Menu Translation. Let us know if this will be incorporated in ET or stay as a separate project. Thanx.

CommentFileSizeAuthor
#3 i18n_entity_translation.module.txt10.62 KBbforchhammer

Comments

bforchhammer’s picture

bforchhammer commented

I have just committed a lot of changes to the menu-link-language-none branch, which makes the integration work with the patch committed to i18n_menu earlier today.

As proposed in #1182058: Add Entity Translation (entity_translation) support for menu items using Menu Translation, the branch supports both items with LANGUAGE_NONE as well as items with a specified language. The entity translation form will contain either a string localization form for the title and description strings (in the case of no language), or the normal "Menu item form" which you usually get on the node edit form (in the case of a specified language).

You can switch from LANGUAGE_NONE to a language by editing the item in the menu items list.

Please test, review, discuss... :-)

klonos’s picture

klonos
he/him
Primary language English
Location 90% Melbourne, Australia - 10% Larissa, Greece
commented

Anything specific you want to test Benedikt?

BTW... Is there an issue to include your work in either ET or i18n we can follow? My concern is that if this code gets included in a future version of one of these modules (I always use their latest devs), then I'll have to make sure I remove the separate module first.

bforchhammer’s picture

bforchhammer commented
StatusFileSize
new i18n_entity_translation.module.txt10.62 KB

Anything specific you want to test Benedikt?

There are different use cases, so it would generally be good to know whether it does what people expect it to do... Apart from that a code review for i18n_entity_translation.module would be helpful...

Is there an issue to include your work in either ET or i18n we can follow?

Not yet, but I will keep updating this one.

jose reyero’s picture

jose reyero commented

Now we have some support built into i18n for ET, it is not that clear for me the problem this module is trying to fix. So maybe it would be good to start with some plain English text about what this module actually does.

Also we should make sure it doesn't make more sense to include some parts of this into ET module itself, as @klonos points out (#2)

Related #1182058: Add Entity Translation (entity_translation) support for menu items using Menu Translation

bforchhammer’s picture

bforchhammer commented

Right, I should have explained that somewhere... ;-)

#1182058: Add Entity Translation (entity_translation) support for menu items using Menu Translation adds support for entity translation (as in "don't touch it if it has ET"); the purpose of this module/patch is to integrate menu translation into the ET translation workflow:

It adds a "menu translation" form to the entity translation form, so that users can translate menu items at the same time when adding/editing the translation of a node

  • Both types of menu items are supported:
    • If the menu item is language neutral, a string translation form is added (here is an early screenshot from the other issue)
    • If the menu item of the source node has a language, then a "normal menu form" is added (which allows to create a new separate menu item for the translation of the node/entity)
  • It ensures that the menu edit form matches the language of the node being edited (language neutral menu items would normally always show up in the site's default language)

Also we should make sure it doesn't make more sense to include some parts of this into ET module itself, as @klonos points out (#2)

I am very happy to create a patch if that's the way forward. It's just easier to work for me in a sandbox at the moment.

klonos’s picture

klonos
he/him
Primary language English
Location 90% Melbourne, Australia - 10% Larissa, Greece
commented

It adds a "menu translation" form to the entity translation form...

Perhaps if the project's name was "i18n *Menu* Entity Translation" that would be clear from the start ;)

colan’s picture

colan
he/him
Primary language English
Location Toronto 🇨🇦
commented

Thanks for the explanation! So, just to clarify, this module isn't needed to get things working, just to improve the UI. As in, it's still possible to follow the process over at http://drupal.org/node/1182058#comment-5605616 with the less-than-optimal UI? (I'll be trying that again in a few minutes now that I brought core and all of my modules up-to-date.)

I am very happy to create a patch if that's the way forward. It's just easier to work for me in a sandbox at the moment.

Yes, this needs to be an ET issue + patch. If you prefer working in a sandbox, how about starting with a clone of ET, and then your series of commits here (as one big diff) could be the patch for the ET issue? You'd probably be able to get more help from us in the ET issue, as we could more easily see what's being changed.

bforchhammer’s picture

bforchhammer commented
Status: Active » Closed (duplicate)

As in, it's still possible to follow the process over at http://drupal.org/node/1182058#comment-5605616 with the less-than-optimal UI?

Correct.

Yes, this needs to be an ET issue + patch. If you prefer working in a sandbox, how about starting with a clone of ET, and then your series of commits here (as one big diff) could be the patch for the ET issue? You'd probably be able to get more help from us in the ET issue, as we could more easily see what's being changed.

Created a new et-patch branch based on a clone of ET. And here's a respective issue on the entity translation queue: #1444866: UI for translation of menu items for entity-translated nodes

Project: » Lost & found issues

This issue’s project has disappeared. Most likely, it was a sandbox project, which can be deleted by its maintainer. See the Lost & found issues project page for more details. (The missing project ID was 1433398)