when i click on another user profile foto the "picture changer" opens with my profile foto options or opens empty.
I think it should show the user foto from the user that is being edited and only if the loged user have permitions to edit it.

CommentFileSizeAuthor
#4 profile_pic_changer-1433700-4.patch5.48 KBskein
#3 profile-picture-changer-1433700-1.patch467 bytesNenadP

Comments

paulap’s picture

paulap commented

YES!!!!!

Please correct.

Best way is to disable this function on user profile pictures of other users.

Thx

SunnyJ’s picture

SunnyJ commented

I'm also using this module, but clicking on another person's picture loads your own picture changer... any fix?

NenadP’s picture

NenadP commented
Status: Active » Needs review
StatusFileSize
new profile-picture-changer-1433700-1.patch467 bytes

I worked a little on this issue.
This simple patch gets current viewed account uid in another way.

Please test and see if it works for you.

skein’s picture

skein commented
Issue summary: View changes
StatusFileSize
new profile_pic_changer-1433700-4.patch5.48 KB

Hello,

I stumbled upon this issue and I decided to refactor the module a bit and fix a few issues with it. I've attached a patch with my changes.

deeray’s picture

deeray commented

Hi, skein I really don't know how to apply patches yet. can this patch be applied to a new version?

skein’s picture

skein commented

Hi. What do you mean the new version? This patch is to be applied to 7.x-1.1.

Here's a page to help you applying the patch: https://drupal.org/patch/apply

flaviovs’s picture

flaviovs commented
Status: Needs review » Closed (duplicate)

Fixed by #1433700: user and permitions are not being checked.

@skein, about the patch in #4, it would be nice if you open another issue and post our patch there, because it contains several fixes that are unrelated to this issue. This way we can better keep track of fixes. Thanks.

Donit’s picture

Donit commented
Status: Closed (duplicate) » Needs review

Not a duplicate. flaviovs link links to this.

flaviovs’s picture

flaviovs commented
Status: Needs review » Closed (duplicate)

@Donit, sorry for the wrong link.

Actually this is a duplicate of -- and was fixed by -- #2470045: Click to edit Pictures is also working on viewing other users profile..

Donit’s picture

Donit commented

Thanks, flaviovs!