Closed (fixed)
Project:
Fancy Login
Version:
6.x-1.7
Component:
Code
Priority:
Normal
Category:
Bug report
Assigned:
Unassigned
Issue tags:
Reporter:
Created:
9 Feb 2012 at 14:09 UTC
Updated:
19 Feb 2014 at 08:30 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
iva2k commentedPlease post more details:
Comment #2
fehin commentedI noticed that when I go directly to https://www.mysite.com/user/login, I'm able to login but when I use the login link which uses fancy login module (http://drupal.org/project/fancy_login), I get the message. Fancy login keeps you on the same page after you login using a url like this https://www.mysite.com/user/login?destination=catalog/1006 while the regular login url (https://www.mysite.com/user/login) takes one to account page. When I use the login link, it takes me to the https://www.mysite.com/user/login screen but displays the url https://www.mysite.com/user/login?destination=catalog/1006 or any page I was on and then display the error message. Even on this page, I'm still not able to login unless I remove ?destination=catalog/1006 from the url.
So I'm assuming this module doesn't mesh well with fancy login module. This problem doesn't occur all the time but when it does almost impossible to login unless you know the direct url to the login page or request a new password. My concern is my users won't know what to do.
Comment #3
iva2k commentedThanks for the info - it is very helpful.
Quick fix is to remove login form from Botcha.
Botcha is very efficient during registration, and further protection on login form is only an added layer if protection from small amount of spammers who do manual registration, but then send bots to login and spam.
Comment #4
fehin commentedI have attached an image to show that even on the login page, with ?destination=catalog/1006 attached to it, I'm not able to login. It worked only if I directly visit https://www.mysite.com/user/login.
Comment #5
fehin commentedThanks for the tip. I thought of doing that earlier but the options were user_login and user_login_block. I thought since I was using a link, it didn't apply to me. I removed from user_login and it works now.
Comment #6
fehin commentedComment #7
iva2k commentedI still want to take a look at what conflict fancy_login module creates and possibly improve Botcha.
Comment #8
iva2k commentedI investigated what is going on, and found the source of the problem in fancy_login/scripts/fancy_login.js.
In a nutshell, fancy_login.js, when displaying the login dialog popup, replaces the form action attribute and discards all query values added by BOTCHA. It breaks BOTCHA functionality which exhibits as the posted error.
There is nothing that can be done in BOTCHA to fix that. But fortunately there is very simple patch for fancy_login.js, which I included here. It essentially merges all query elements already present in the form action attribute into the new action URI that is generated from the link. It works nicely with BOTCHA and have no effect without BOTCHA.
Moving to fancy_login.module queue for attention of community - please review and post your RTBC for the maintainer to commit.
I suspect it will also fix same problem that probably exists in 7.x-1 branch.
Comment #9
iva2k commentedupdating tags
Comment #10
iva2k commentedPatch escaped from the post #8. Here it is.
Comment #11
jaypanThank you for the patch. However, I've decided to drop support of Version 6.x-1.x in favor of version 6.x-2.x which is a backport of version 7.x-3.x.
The method I've used for setting up the module should integrate better with other modules, so this issue should have been fixed. Please upgrade and test again. If the issue is not fixed, please re-open and set the version to 6.x-2.x.