I was debating going with this but I have several problems with it. However, the kicker was that it doesn't appear to integrate with the location.module at all... and it should.

Some of the other things that were bothering me:

1) Can't disable the Apt field (in my case, there's no way anyone would have an apartment and we would specifically want to disallow anyone who did from filling out the form).

2) Having to fill out a label for a set of fields is weird. Seems to conflict with the concept of a Group, and/or be redundant.

My suggestion: try breaking this meta field into several smaller/individual fields:

* Address (can be used twice as a 1-line textarea, or once as a 2-line textarea)
* Apt/Suite (for situations where you need to track it separately from Address Line 2)
* City (U.S. version includes updated list of cities per state)
* County (U.S. version includes updated list of counties per state)
* State (U.S. version includes updated list of states)
* Province (Canadian version includes updated list of provinces)
* Country (includes updated list of countries)
* Zip Code (U.S. version includes free updated list of U.S. ZIP Codes)
* Postal Code (Canadian version includes free updated list of Canadian postal codes).

You would keep them all in the same module, of course, but this arrangement would solve #1 and #2 for me above and seems to make more sense and provide more flexibility.

Finally, I would take this one step further by integrating with Location.module instead of the crappy form they've got going on right now for nodes that want to hold locative data, because without all that proximity searching, geocoding, and GMap ability, I won't be able to use this module. Just my two cents.

Hope this helps! :)

Comments

rconstantine’s picture

rconstantine commented
Status: Active » Postponed

To respond to your suggestions:

1) Feel free to roll a patch to show/hide apartments/suites or even hide/show the other or Street2 fields.

2) I'm not sure what you mean. Why is it weird to label a 'Home Address' or a 'Business Address'? What do you mean by 'Group'? Are you talking about cck fieldgroup? If so, I don't see that the label of the fieldgroup shows up on the node view, so I'm not seeing any redundancy.

There are too many changes year after year to have an up-to-date city list. There are 5 new cities in my area in the last 8 years. I don't know of a free data source that is up-to-date. Likewise, the free sources for zip codes are a few years old as well. That may be fine for areas without much population growth, but not for those with such growth.

I'm really not interested in geocoding at this point in time, although if I need it later, obviously, I'll add it. I currently just need to know where people live. This module does that for me. I don't need international usage at all, but thought I'd at least put something basic in, which is why I've got the Canada part and other people can add more.

If you or someone else would like to integrate location.module with this or visa-versa, I'm open to reviewing any patches.

In other words, I've got a dozen or more modules that I now need to work on, so aside from bug fixes, this module won't change much until these are done.

I'm sorry that this module isn't what you need. But that's the cool thing about Drupal - you can code exactly what you DO need, yourself.

Cheers.

ms2011’s picture

ms2011 commented

Well said. If this does end up being something I truly need, I will definitely keep you posted with any patches. :)

rconstantine’s picture

rconstantine commented
Status: Postponed » Closed (won't fix)