Hi

I' not sure it's a bug but seems to me logical. When you configure a "do nothing" propretie for the nodetitle plugin as a result of a content not found, you expect not to see brackets. Ideally, if you enter a [[my mode title|title]] you should see "title", instead of [[my mode title|title]] in the text if my-node-title doesn't exist.

Thank in advance for this feature, if it's possible.

CommentFileSizeAuthor
#3 show_text-1434486-3.patch4.54 KBmisc

Comments

Alessandro Pezzato’s picture

Alessandro Pezzato commented

Subscribe. I think this is a more intelligent way to do nothing.

misc’s picture

misc commented

I agree, I will look into a patch for this.

misc’s picture

misc commented
StatusFileSize
new show_text-1434486-3.patch4.54 KB

I went thinking on the semantics, 'Do nothing' felt like it really should be 'Do nothing'. Instead I created a new plugin, Show text, that just shows the text inside the freelinking-field instead, and could be choosed from the fallback settings for the Nodetitle-settings. Attached patch.

Roulion’s picture

Roulion commented

@MiSc : your way souds the better. I will test it tonight. Thanks.

juampynr’s picture

juampynr commented
Title: Nodetitle : do nothing if not found » Print title if no content was found when using Nodetitle plugin
Issue tags: +needs backport to 6.x

Committed. Would be nice to reflect this on the tests.

I have restored the ".=" at $extra_description, in case it is coppied and pasted again. I found out that if you had the Search module disabled, the variable was being reset and the alert for "Enable freelinking create" was not being shown.

This needs a port for the 6.x-3.x branch too.

http://drupalcode.org/project/freelinking.git/commitdiff/695a58b

Roulion’s picture

Roulion commented

I tested it and it seems OK for me

Thank you very much

juampynr’s picture

juampynr commented
Version: 7.x-3.x-dev » 6.x-3.x-dev

Changed branch in order to back-port it.

  • gisle committed 0363a57 on 6.x-3.x 
    #1434486 by gisle: Added failback setting (Show text) to strip brackets...
gisle’s picture

gisle
he/him
Primary language Norwegian Bokmål
Location Norway
commented
Assigned: Unassigned » gisle
Issue summary: View changes
Status: Active » Needs review
Issue tags: -needs backport to 6.x

A new setting ("Show text (remove markup)") has been added to the Nodetitle plugin list of failbacks. Selecting this will just show the text (no brackets).

The "Do nothing" failback will work as before, and will show the brackets.

This has been pushed has been pushed to the HEAD of 6.x-3.x-dev. Please review.

gisle’s picture

gisle
he/him
Primary language Norwegian Bokmål
Location Norway
commented
Status: Needs review » Fixed

This fix is included in the 6.x-3.5 release.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.