Active
Project:
CKEditor 4 - WYSIWYG HTML editor
Version:
6.x-1.x-dev
Component:
Code
Priority:
Critical
Category:
Bug report
Assigned:
Reporter:
Created:
9 Feb 2012 at 22:11 UTC
Updated:
10 Sep 2013 at 07:44 UTC
I have jQuery UI 1.8.11 and in that case you fallback on a load that doesn't work in the current development version.
if (jquery_ui_get_version() > 1.6) {
// jquery_ui_add(array('jquery.ui.sortable')); -- not enough!
jquery_ui_add(array('jquery-ui', 'jquery.ui.widget', 'jquery.ui.sortable'));
}
The patch includes a fix to the indentation and additional { and } that are required (in Drupal) even when an if() is followed by a single line of code. Plus, it's good practice.
Thank you.
Alexis
| Comment | File | Size | Author |
|---|---|---|---|
| ckeditor-6.x-jquery_ui.patch | 1.94 KB | AlexisWilke |
Comments
Comment #1
AlexisWilke commentedOne other note...
The files are named jquery.ui.something. In the original, the "jquery." part was missing.
Thank you.
Alexis
Comment #2
mkesicki commented@AlexisWilke thank you for patch.
Comment #3
dczepierga commentedFirst of all, jquery_ui module support only jQuery UI up to 1.7.3 version... from version 1.8 jQuery UI has prefix
jquery.before each file.The second thing is does
jquery_ui_get_versionfunction work only up to 1.7.3 version of JQuery UI, so with newer version it wouldn't be work and will be return0.Also before jQuery UI 1.8 u doesn't have something like jquery.ui.widget so it doesn't help.
So i think this issue can be closed, because it doesn't make sense.
Greetings
Comment #4
AlexisWilke commentedI have jquery 1.5.2 and jquery.ui 1.8.11. So that explains the problem. I suppose the patch would need to test the version of jquery.ui but how to get that version if you cannot load the library first?! 8-)
Anyway, thank you for looking into it and explaining the situation.
Alexis
Comment #5
wwalc commentedOne user reported the same problem, so it looks like there is something wrong here.
Well, at least we should detect incompatible/wrong configuration and load appropriate files when needed.