Hi

I am using Advertisement 6.x-2.2 and I have tried both Ad Flash 6.x-2.7 and the latest .dev release dated 2011-12-21. Clicking on my flash advert takes me to a new browser tab with the URL saying "undefined" and the standard "page not found" displayed.

My advert was supplied by a large agency and is for a major corporate so I'm presuming it is fine.

Looking at the page source ( with the .dev version of this module ) I see the following as part of the object tag :

<param name="flashvars" value="clickTAG=http://mydomain.com/ad/redirect/6513/0?url=node/6505">

6513 is the nid of the advert node and 6505 is the nid of the page the advert is displayed on.

Any suggestions much appreciated.

Thanks

CommentFileSizeAuthor
#9 ad_flash.module.patch1.24 KBlazly

Comments

El Bandito’s picture

Quick followup. If I enter the url from the clickTAG parameter ( i.e. http://mydomain.com/ad/redirect/6513/0?url=node/6505 ) directly into my browser address bar it redirects successfully to the correct external destination URL.

El Bandito’s picture

OK. This was a result of the infamous "clickTag" problem. This module is hardcoded to send the parameter as "clickTAG" but my advert was expecting "clickTag".

Changing line 605 in ad_flash.module to :

$output .= 'var flashvars = {clickTag:"'.$ad->redirect.'/@HOSTID___"};';

fixed the problem for me.

Alex Andrascu’s picture

Umm...hardcoded ?
Maybe not.
Syntax is clickTAG not cLicKTag or whatever a major agency decides it's correct.
Maybe send this back to the major agency http://www.adobe.com/resources/richmedia/tracking/designers_guide/

El Bandito’s picture

Status: Active » Closed (works as designed)

Alex

I'm sure you're right and your link supports your assertion. However I can see from the issue queue that others have fallen into this trap.

Perhaps it would be an idea to make it default to "clickTAG" but with the option of specifying something else ?

Thanks for the great module.

El Bandito’s picture

In fact even the Adobe doc you reference is inconsistent. It states use :

on (release) {
if (clickTAG.substr(0,5) == "http:") {
getURL(clickTAG);
}
}

but the example dialog box image shows :

on (release) {
if (ClickTAG.substr(0,5) == "http:") {
getURL(clickTAG);
}
}

Ho Hummm

Alex Andrascu’s picture

David,

It might make sense to have this kind of feature in the end as i'm tired to see people falling into traps by now :) .
I'm willing to review and commit any sensible patches addressing this issue.

Hope it helps.
Alex

Alex Andrascu’s picture

Status: Closed (works as designed) » Active
Alex Andrascu’s picture

Category: bug » feature
lazly’s picture

Category: feature » bug
Priority: Normal » Major
Status: Active » Patch (to be ported)
StatusFileSize
new1.24 KB

#2 is work for me too, a made a patch, please commit to source. Its not a feature request, if its not commited to your code your clicks will be not work AND not counted too. Comment: Its looks like the flash vars are case sensitive.

Alex Andrascu’s picture

Thanks for the patch ! Will commit.

Alex Andrascu’s picture

Priority: Major » Normal
lazly’s picture

Your welcome, thanks your work too! ;)