Original issue
#1077602: Convert node.tpl.php to HTML5
Participants
Jacine, Everett Zufelt, dcmouyand, scor, Jeff Burnz, webchick, cleaver, casey, cosmicdreams, skottler, sanduhrs, matglas86, jasonsavino, klausi, JohnAlbin, yched, catch, sun, nimbupani
Core commit
11/13/2011 by catch: b77a0c1
Commit message
Issue #1077602 by Jacine, dcmouyard, skottler, jasonrsavino et al: Convert node.tpl.php to HTML5.

Original Post

Patch three!
From #1077602: Convert node.tpl.php to HTML5

CommentFileSizeAuthor
#3 1436336-03.patch5.54 KBjacine
#1 node-tpl.patch5.91 KBSnugug
node-tpl.patch5.9 KBSnugug

Comments

Snugug’s picture

StatusFileSize
new5.91 KB

Up, put node.tpl.php was in the wrong spot. Hopefully didn't mess up the whole patch by moving the template file there. New patch!

jacine’s picture

Status: Needs review » Needs work

Hey, thanks @Snugug!

There are a couple of issues (mostly nitpicky stuff) with the patch, for future reference:

+++ b/template.phpundefined
@@ -82,4 +82,14 @@ function html5_process_html(&$variables) {
+ * Implements the THEME_process_HOOK().

This should just read "Implements hook_preprocess_node()."

+++ b/template.phpundefined
@@ -82,4 +82,14 @@ function html5_process_html(&$variables) {
+ * - #1077602: Adds Article role to Attributes Array

The issue title should match the current issue. The inline comment should note the actual change.

+++ b/template.phpundefined
@@ -82,4 +82,14 @@ function html5_process_html(&$variables) {
+function html5_process_node(&$variables) {

This is actually done in preprocess, not process.

+++ b/templates/node/node.tpl.phpundefined
@@ -0,0 +1,110 @@
+  <?php print $user_picture; ?>

This variable is printing twice in the patch. The Drupal 7 version does have this variable at the top, and it's actually an annoying bug that we cannot fix (template changes like this are not backport-able because they can wreak havoc on existing themes). The one inf the is the one we need.

Since I'm here working on it, I'm going to re-roll and commit.

I also need to pull the names of the people that worked on it and give them commit credit.

jacine’s picture

Issue summary: View changes

Added information about original core patch.

jacine’s picture

Status: Needs work » Needs review
StatusFileSize
new5.54 KB

Here's the updated patch.

jacine’s picture

Title: Updated node.tpl.php » Add modified version of node.tpl.php

Changing title to match the same pattern as the others.

jacine’s picture

Status: Needs review » Fixed

Ok, this one is committed. Also pushed a bunch of commits to credit people for all the previous patches.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

Anonymous’s picture

Issue summary: View changes

Updated issue summary.