Closed (fixed)
Project:
HTML5
Version:
7.x-1.x-dev
Component:
Templates
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Reporter:
Created:
10 Feb 2012 at 20:22 UTC
Updated:
25 Feb 2012 at 22:20 UTC
Jump to comment: Most recent file
Issue #1077602 by Jacine, dcmouyard, skottler, jasonrsavino et al: Convert node.tpl.php to HTML5.
Patch three!
From #1077602: Convert node.tpl.php to HTML5
| Comment | File | Size | Author |
|---|---|---|---|
| #3 | 1436336-03.patch | 5.54 KB | jacine |
| #1 | node-tpl.patch | 5.91 KB | Snugug |
| node-tpl.patch | 5.9 KB | Snugug |
Comments
Comment #1
Snugug commentedUp, put node.tpl.php was in the wrong spot. Hopefully didn't mess up the whole patch by moving the template file there. New patch!
Comment #2
jacineHey, thanks @Snugug!
There are a couple of issues (mostly nitpicky stuff) with the patch, for future reference:
This should just read "Implements hook_preprocess_node()."
The issue title should match the current issue. The inline comment should note the actual change.
This is actually done in preprocess, not process.
This variable is printing twice in the patch. The Drupal 7 version does have this variable at the top, and it's actually an annoying bug that we cannot fix (template changes like this are not backport-able because they can wreak havoc on existing themes). The one inf the is the one we need.
Since I'm here working on it, I'm going to re-roll and commit.
I also need to pull the names of the people that worked on it and give them commit credit.
Comment #2.0
jacineAdded information about original core patch.
Comment #3
jacineHere's the updated patch.
Comment #4
jacineChanging title to match the same pattern as the others.
Comment #5
jacineOk, this one is committed. Also pushed a bunch of commits to credit people for all the previous patches.
Comment #6.0
(not verified) commentedUpdated issue summary.