API page: http://api.drupal.org/api/drupal/core%21modules%21field%21field.module/g...

This group/topic page is hard to scan. It could be a lot more readable if our list formatting guidelines were followed (e.g., colons). See
http://drupal.org/node/1354#lists

Comments

scorchio’s picture

Status: Active » Needs review
StatusFileSize
new16.6 KB

Could someone review this please? This patch adds the missing colons and rewraps the comments as necessary.

jhodgdon’s picture

Status: Needs review » Needs work

Please read http://drupal.org/node/1354#lists again. The indentation is not correct. Thanks!

scorchio’s picture

Status: Needs work » Needs review
StatusFileSize
new17.34 KB

Ooops, sorry for that... Hopefully this one is a better try :)

jhodgdon’s picture

Status: Needs review » Needs work

That's better! A couple of additional fixes are needed:

a)

+ *   within Field API.
+ *   When a field is attached to an entity, the field's data is stored
+ *   in $entity->$field_name. Maximum length is 32 characters.

This is all one paragraph. The 2nd line here needs to be moved up to the first line and then the rest re-wrapped to 80-character-max lines.

b)

+ * - widget (array): A sub-array of key/value pairs identifying the Form API
+ *   input widget for the field when used by this bundle.
+ *   - type (string): The type of the widget, such as text_textfield. Widget

The sub-list here should be preceded by : (at the end of the 2nd line). The next few list/sublists in the patch have the same problem.

kid_icarus’s picture

StatusFileSize
new16.91 KB

Well, here goes my second patch, hope it works out :)

cweagans’s picture

Status: Needs work » Reviewed & tested by the community

Talked to kid_icarus about the trailing whitespace that I found. Other than that, this looks RTBC.

kid_icarus’s picture

Status: Reviewed & tested by the community » Needs review
StatusFileSize
new16.91 KB

Fixes #6 as pointed out by cweagans.

cweagans’s picture

Status: Needs review » Reviewed & tested by the community

Perfect. Welcome to core contribution, kid_icarus!

jhodgdon’s picture

Status: Reviewed & tested by the community » Fixed

Committed to 8.x and 7.x. Congratulations on your first core patch kid_icarus, and thanks scorchio for the original patch too!

Automatically closed -- issue fixed for 2 weeks with no activity.