Original issue
#1189816: Convert comment.tpl.php to HTML5
Participants
Jacine, Jeff Burnz, scor, rasskull, dcmouyard, ericduran, Everett Zufelt, stijnbe, jessebeach, franz, droplet, linclark, sun, webchick, stevetweeddale, lasac
Core commit
12/5/2011 by Dries: faddd57
Commit message
- Patch #1189816 by Jacine, Jeff Burnz, stijnbe, scor, rasskull, jessebeach, ericduran, sun: Convert comment.tpl.php to HTML5.

Original Post

Numero cinco!
From #1189816: Convert comment.tpl.php to HTML5

CommentFileSizeAuthor
#4 comment-tpl.patch4.53 KBSnugug
comment-tpl.patch4.48 KBSnugug

Comments

jacine’s picture

Status: Needs review » Needs work

Hey, this patch won't apply because it's expecting changes from one of your other patches. Generally, it's a good idea to do patches on a fresh copy of the repository without any changes.

+++ b/template.phpundefined
@@ -92,4 +92,14 @@ function html5_process_html(&$variables) {
+/**
+ * Implements the THEME_process_HOOK().
+ *
+ * Backports the following variable changes to Drupal 8:
+ * - #1189816: Adds user_picture variable for use in Comments.

This comment block needs work. See the recent commits for an example.

+++ b/template.phpundefined
@@ -92,4 +92,14 @@ function html5_process_html(&$variables) {
+function html5_process_comment(&$variables) {

This is done in preprocess, not process. Make sure to update the implements hook too. :)

+++ b/template.phpundefined
@@ -92,4 +92,14 @@ function html5_process_html(&$variables) {
\ No newline at end of file

This shouldn't happen. There should always be an empty line at the bottom of each file.

jacine’s picture

Title: Updated comment.tpl.php » Add modified version of comment.tpl.php

Updating title.

Snugug’s picture

I thought that may be the issue, will re-roll fresh.

Snugug’s picture

Status: Needs work » Needs review
StatusFileSize
new4.53 KB

And again.

jacine’s picture

Status: Needs review » Fixed

Perfect! Committed :D

Snugug’s picture

Status: Fixed » Closed (fixed)

Since this is fixed and committed, I'm going to close (fixed) this!

webchick’s picture

Issue summary: View changes

Add core issue information.