Closed (fixed)
Project:
HTML5
Version:
7.x-1.x-dev
Component:
Templates
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Reporter:
Created:
10 Feb 2012 at 21:33 UTC
Updated:
5 May 2012 at 08:40 UTC
Jump to comment: Most recent file
- Patch #1189816 by Jacine, Jeff Burnz, stijnbe, scor, rasskull, jessebeach, ericduran, sun: Convert comment.tpl.php to HTML5.
Numero cinco!
From #1189816: Convert comment.tpl.php to HTML5
| Comment | File | Size | Author |
|---|---|---|---|
| #4 | comment-tpl.patch | 4.53 KB | Snugug |
| comment-tpl.patch | 4.48 KB | Snugug |
Comments
Comment #1
jacineHey, this patch won't apply because it's expecting changes from one of your other patches. Generally, it's a good idea to do patches on a fresh copy of the repository without any changes.
This comment block needs work. See the recent commits for an example.
This is done in preprocess, not process. Make sure to update the implements hook too. :)
This shouldn't happen. There should always be an empty line at the bottom of each file.
Comment #2
jacineUpdating title.
Comment #3
Snugug commentedI thought that may be the issue, will re-roll fresh.
Comment #4
Snugug commentedAnd again.
Comment #5
jacinePerfect! Committed :D
Comment #6
Snugug commentedSince this is fixed and committed, I'm going to close (fixed) this!
Comment #6.0
webchickAdd core issue information.