Originally, I had thought perhaps the Flash never initializes in this module but further inspection has led me to the conclusion that jwplayer('<?php print $html_id ?>').setup(<?php print $jw_player_inline_js_code?>); somehow never executes. There is a multifaceted problem here, actually. I'll do my best to explain what I am finding:

  • In the tpl.php file you use the <video> tag - Not sure if this is an issue (yet) but let's say a person chooses Flash as the primary, or the fallback is Flash. I don't believe the JS will attach properly to that tag if a browser has no idea how to read it. Edit: Looks like this is the recommended way, so ignore this piece.
  • Even if the JS does attach, I have shaken out that the setup() code never actually fires the right way. For example, if I replace the entire contents of the video tag with a simple div tag instead (inside my theme's tpl.php override) the player never shows up as Flash. Although the configurations can be seen in the setup() call (therefore I know they are being set properly), (where modes is clearly Flash first) it just creates the markup required to display HTML5.

Using theme_jw_player to get this to appear but no Flash works as of yet.

I am still shaking this out. So this is more a stub while i find out what needs to be patched. Browsers which work: Web-kit - Browsers which do not: Firefox/Gecko

Stay tuned.

Comments

webkenny’s picture

webkenny commented

Ok, I think I might have this problem identified but not sure if it's in the module or in the JW Player library. Here it is. The flash mode doesn't work, therefore it falls back to the 2nd mode (HTML5) - Since some versions of Firefox (I have 9 on this machine, for example) don't support HTML5 - nothing shows up. In a Webkit browser, like Safari, it properly falls back to HTML5.

So actually it's just that the Flash bits never actually get triggered. Continuing to investigate why. This very well could be something in the JW package or some configuration on the site preventing it. Should know more soon.

rickvug’s picture

rickvug commented

I'm glad that you're taking a look into this. I'll try to help out where possible and be reasonably quick to respond. I know that others have had issues with Firefox (see #1394304: How to play flv videos on Ipad) but my understanding up until this point was that the problem only crops up if the user hasn't installed Flash. Perhaps this isn't the case.

For the HTML5 video tag I'd like to add an option to switch between a embedding over top of a div instead of a video tag. Simply using a div is the most common way to use JW Player but the video tag is more semantic and also approved in the JW Player docs. The switching should be automatic in cases such as when playing back audio rather than video. This issue is fairly closely related: #1370670: Add template suggestions per file type for more sensible theming.

For the JavaScript embedding I did add an inline embedding option a while ago (see the settings). I tend to use this option all of the time so it could be that regressions with the normal JavaScript embedding slipped in unnoticed. The main reason for using the inline embedding is so that videos inserted into text fields via Media module will play back, even when cached (the JavaScript gets cached along with the text rather than being placed on the top of the page only on initial display).

Some of this information will not directly relate to this bug but hopefully the general background proves helpful when working on the module.

webkenny’s picture

webkenny commented
Status: Active » Closed (works as designed)

Actually this is a major fail in the JavaScript API for JW Player (your module works beautifully) - When you load a video format that, for example, Flash does not handle it just fails and doesn't notify the end user. Looks like there is a bug to be filed for JW Player!

Thank you for your response. I'll get the feature request filed with Longtail.

rickvug’s picture

rickvug commented

What version of JW Player are you using? I haven't tried 5.8 or 5.9 yet. Hopefully upgrading fixes a few bugs.

webkenny’s picture

webkenny commented

Seems this happened in both from 5.8 to 5.9 - Total failure on their part.

Sorry for sullying up the issue queue. Although I do have a big interest in this module. I use JW on many Drupal sites and this is the cleanest implementation I've seen so far in 6 or 7. You'll be seeing me much more in your issues. Very interested in helping you work through any bugs/features. I'll keep my eyes open for areas I can help.

Thanks for your quick responses.

mgifford’s picture

mgifford
he/him
Primary language English
commented

We're running into this issue with 5.10 at the moment. Is there a related issue queue within http://www.longtailvideo.com/support/forums/jw-player/setup-issues-and-e... that this should be linked to?

I'm not sure how decisions get made & bugs get fixed in the JW Player community.

mgifford’s picture

mgifford
he/him
Primary language English
commented
Issue summary: View changes

Removing information regarding the video tag. It is, in fact, supported to do it this way.