I am using the module to override the user/register page and saw an error where certain pages (like user/register) don't have any load arguments and it returns an empty value. However, since the assumption is that it is an array it throws a notice. This patch will provide an empty array instead of the empty string.

CommentFileSizeAuthor
#2 1437806-la-array.patch660 bytesandypost
pm_existing_pages_load_function_array.patch529 bytespopulist

Comments

andypost’s picture

andypost
he/him
Primary language Russian
commented
Version: 7.x-1.1 » 7.x-1.x-dev

I think this has a same troubles as #1440068: Wrong usage of arguments

SO we need to fix logic within menu alter

andypost’s picture

andypost
he/him
Primary language Russian
commented
Status: Needs review » Reviewed & tested by the community
StatusFileSize
new 1437806-la-array.patch660 bytes

Re-roll patch (using git diff - p1 core's standard)

I think module should check for page callback too for example trying to override /user/login

swentel’s picture

swentel commented
Status: Reviewed & tested by the community » Fixed

Nice catch, committed and pushed, thanks!

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.