Notice: Undefined variable: inpage in itweak_login_form_alter() (line 108 of itweak_login.module).
Notice: Undefined index: #weight in itweak_login_form_alter() (line 142 of itweak_login.module).
Notice: Undefined variable: inpage in itweak_login_form_alter() (line 145 of itweak_login.module).

anyone else with this same issue?

CommentFileSizeAuthor
#1 itweaklogin-phpnotices-1438000-0.patch1.14 KBtheohawse

Comments

theohawse’s picture

theohawse commented
StatusFileSize
new itweaklogin-phpnotices-1438000-0.patch1.14 KB

Honestly not sure if this is a real fix, but at least gets rid of the errors for me :)

theohawse’s picture

theohawse commented
Status: Active » Needs review
iva2k’s picture

iva2k commented
Priority: Normal » Minor
Status: Needs review » Fixed

1. Notice is not an error. I guess you enabled these notices in your PHP setup (it comes off by default, so it is not seen by others).

2. Your patch reverses the logic on line 146, and therefore breaks the existing functionality.

3. Second notice is not addressed by the patch (Undefined index #weight)

Thanks anyway, I can checkin a complete fix to -dev now that properly corrects all 3 notices.

theohawse’s picture

theohawse commented

Cool! Thanks for the insight, am just a wee toddler with this php stuff :)

Also thanks for making all my sites easier to tweak, oh and thanks for helping clean up the warnings in my logs.

Sortof enabled E_Notices yeah, and have almost gotten to the bottom of them all!
Had read somewhere that this can be a security issue, I don't want to just ignore things like that by hiding the notices.

After all the endgame to build the most excellent cms ever made right?

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

Anonymous’s picture

(not verified) commented
Issue summary: View changes

cleanup