Closed (outdated)
Project:
Masquerade
Version:
7.x-1.x-dev
Component:
Code
Priority:
Normal
Category:
Feature request
Assigned:
Unassigned
Reporter:
Created:
13 Feb 2012 at 03:03 UTC
Updated:
17 Apr 2026 at 12:43 UTC
Jump to comment: Most recent
Comments
Comment #1
robertstaddon commentedThis would be an extremely valuable feature to add!
Comment #2
wjaspers commentedThis request would depend on:
#1458418: Add masquerade events API
And therefore, this request had already been moved to (somehow I forgot about this post):
#1458334: Add Rules support
Comment #3
deekayen commentedI don't think we need an events API to support Rules. Rules is popular enough to get bumped ahead of a generic API integration if someone submitted a patch for it.
Comment #4
wjaspers commentedThen, for example, the implementation of capturing when a user is about to masquerade would be:
I thought initially about going down this road, but it feels too tightly coupled.
Plus, in further thought, we could let other modules stop the masquerade based on custom requirements.
Comment #5
andypostlet's continue in this issue, marked as dumplicated #1458334: Add Rules support
suppose we just need to implement support in masquerade.rules.inc
Comment #6
citricguy commentedWhere should development of this feature continue? It seems like both the Masquerade and Masquerade Extras projects are assuming the other will implement the feature. This seems has been closed in the Masquerade Extras project and marked as a duplicate of this issue.
Comment #7
wjaspers commented@citricguy
That's not quite the case.
The Masquerade module needs to fire the basic hooks necessary for rules to work. Otherwise, the rest of this is not possible.
(For example: module_invoke("masquerade_start")). This thread already suggests the basics for what would be required. #1547058: Add hooks when user starts or stops masquerading
My original suggestion was wrong because rules integration would be coupled to masquerade with hooks specific to rules.
All masquerade_extras would supply is the hooks/events that would be useful to rules.
Whether or not Masquerade's maintainers want that integration in this suite or elsewhere is up to them.
Comment #8
deekayen commentedI would commit a working patch for this.
Comment #9
ressaThanks for working on this. In an attempt to help the maintainers, I am going through some of the Drupal 7 issues, and closing them, since Drupal 7 is EOL.
Maintainers should grant credit for the great work to the relevant users, even if the patch did not get committed: https://www.drupal.org/docs/develop/issues/issue-procedures-and-etiquett....
Since Drupal 7 is EOL, we can probably close this issue, but feel free to re-open if this is still relevant, and we should consider adding this to the Drupal 11 version?