Issue with D6->D7 upgrade path.

Hi,

Token is a requirement of File (Field) Paths in both Drupal 6 and 7, therefore it shouldn't even allow you to run the File (Field) Paths updates without Token enabled. If you could give me some way to attempt to reproduce the issue so I can see it in action I might be able to resolve it.

Cheers,
Deciphered.

Again, as I said, Token is a requirement of File (Field) Paths, so Token would be automatically enabled when you enabled File (Field) Paths... which is why I'm confused.

However I suspect that the issue has nothing to do with Token anyway, I'll try to reproduce the issue shortly and see what I can come up with.

To reproduce:

1. Upgrade a Drupal site from 6->7 following the UPGRADE.txt directions
2. Download updates for all contrib modules
3. Run update.php or drush updb (Don't enable the modules)

Result:

Drush command terminated abnormally due to an unrecoverable error.                                                        [error]
Error: Call to undefined function _filefield_paths_get_field_types() in
/home/user/public_html/sites/all/modules/filefield_paths/filefield_paths.install, line 159
Output from failed command :                                                                                              [error]
 
Fatal error: Call to undefined function _filefield_paths_get_field_types() in
/home/user/public_html/sites/all/modules/filefield_paths/filefield_paths.install on line 159

Temporary workaround is to delete File Field Paths, run update.php for all other new modules, download File Field Paths, and run update.php for File Field Paths.

Ran into the same error.

Drupal will run the upgrades whether the modules are actually enabled or not, so this really needs to be fixed in Filefield Paths.

Adding a drupal_load() to the start of filefield_paths_update_7107() should be sufficient to fix the issue:

/**
 * Removed filefield_paths table/schema.
 */
function filefield_paths_update_7107() {
  drupal_load('module', 'filefield_paths');

  // Remove filefield_paths table/schema.
  ...

I can confirm this error as well. This is a blocker IMO.

The code at #6 seems work.

Ran into this myself. As xtfer says, "Drupal will run the upgrades whether the modules are actually enabled or not." Enabling Token didn't fix it for me, but actually enabling Filefield Paths did. Attached patch throws an exception if either modules are disabled.

I'm inclined to go with a combination of #6 and #9, something that forces the required dependent files to be included and throws an exception if the required files aren't present.

Patches welcome.

Test and confirmed the error and fix, opted to go with just #6 as it just works, Token module doesn't need to be present for the upgrade so no need to warn if it isn't.

Committed.

Thanks.

Thank you! Its worked!

Just Need to turn on the module