Closed (fixed)
Project:
RSVP
Version:
4.7.x-1.x-dev
Component:
Code
Priority:
Normal
Category:
Feature request
Assigned:
Reporter:
Created:
14 May 2007 at 08:38 UTC
Updated:
20 Jun 2007 at 18:14 UTC
This patch applies module update instructions at http://drupal.org/node/64279 to update rsvp module to Drupal 5.x.
to apply the patch follow those instructions:-
- cp rsvp_upgrade_to_5.x.patch [path_of_rsvp_module] (e.g. /var/www/drupal/all/modules/rsvp/ )
- cd [path_to_rsvp_module]
- patch -p1 -R < rsvp_upgrade_to_5.x.patch
| Comment | File | Size | Author |
|---|---|---|---|
| rsvp_upgrade_to_5.x.patch | 18.75 KB | Remon |
Comments
Comment #1
owahab commentedThanks for the effort.
Comment #2
owahab commentedrgeorgy,
I reviewed the code, it's neat and to the point.
I have one single thing to criticize the patch you submitted:
You probably seen how basic 4.7 code was. It wasn't using many features provided by, for example, Forms API.
Your patch is almost the same: it corrects errors in 4.7 to 5 movement but it doesn't implement any of Drupal 5 features.
I believe we need to have the module written in a better way with a tighter integration with similar modules.
I will for sure commit parts of your code or start porting to 5 based on your code but I can't promise that your code will fully appear in 5.x version of the module.
Thank you once again for your work.
Comment #3
owahab commented