Closed (fixed)
Project:
Plup
Version:
7.x-1.x-dev
Component:
User interface
Priority:
Normal
Category:
Task
Assigned:
Reporter:
Created:
13 Feb 2012 at 13:30 UTC
Updated:
16 Jun 2013 at 22:17 UTC
Jump to comment: Most recent, Most recent file


Comments
Comment #1
Fidelix commentedUpdated patch.
Comment #2
Fidelix commentedSame patch with 1 more improvement:
Added a border to the draggable area so the user knows where he can drop the files.

Comment #3
Fidelix commentedSame as before, but with a line-height fix.
Comment #4
Anonymous (not verified) commentedI'll look into it.
Comment #5
fietserwinThese style changes don't work when alt and/or title texts are allowed to be defined by the editor.
So, I think it is not such bad idea to use thumbnails of known predefined dimensions. However this module should define its own image style for that and not "hijack" the Drupal defined thumbnail image style. An example of a module doing so is Linkit (7.x-2.x version), but basically it comes down to defining the hook like below (copied from a features generated module). I found this issue because I had a problem with this module, because my thumbnail dimensions have been overruled for other purposes...
Comment #6
Fidelix commentedfietserwin, I have to disagree.
The ability to define your own image styles for thumbnails is a very good feature of this module, and I strongly believe that it should not be removed.
There are numerous use cases for defining your own image styles.
I have created a patch that has all the previous changes in 1 single commit.
Besides that, it adds a placeholder text to the Title and "Alt Text" input fields, improving usability.
It also adds a proper class to each input field in order to distinguish them, and improves the CSS of the fields to work with any thumbnail size.
Also, it changes the JS behavior so that the fields only appear when hovering over or focusing the thumbnail. I'm not sure if that improves usability, but I did it so the fields don't prevent the user from viewing the thumbnails.
Comment #7
Fidelix commentedThis also contains a small fix to prevent the remove button from going behind the input in a natural way.
If the user focuses on the input field, the remove button will go behind, as expected.
Comment #8
Anonymous (not verified) commentedComment #9
alex.87 commentedCan anyone provide .zip with working patch for various thumbs sizes? I dont have shell access.
Comment #9.0
alex.87 commentedAdded description to images.