By angela.simmons on

Hi All,
I am migrating from Drupal 6 to Drupal 7 and had a Java script related issue which got resolved .

Now i am able to see the pages without the error i used to see earlier. The screen shows the firebug view of the page post the dropdown change and javascript run. The Firebug shows the value of the project ID it acquired but the table shows blank.
This is the method in PHP and this is the table theme used for displaying the table seen in the screenshot.

All this was visible in Drupal 6 but i am unsure as to what additional changes need to be done for Drupal 7. This is the Javascript file used in the entire page for the functionality.

Would like to have your views as to what is missing in the Drupal 7 version of my customization.

Thanks
A

⋅ Categories: Drupal 7.x

Comments

jaypan’s picture

jaypan
Location Victoria, BC
commented

I cannot understand what the problem is. Can you please try explaining it again?

Contact me to contract me for D7 -> D10/11 migrations.
Or anything really. I'm friendly, and open to work or conversation.

angela.simmons’s picture

angela.simmons commented

I have a page where on change of the dropdown box, the table above it gets populated. So if i select a value "Draft" from the dropdown box, the javascript and jquery code works to obtain the list of projects in Draft state (via the web service calls) and the table renders the details obtained in three columns (Project ID, Project Description and Project Status).
This functionality used to run easily in Drupal 6 but in Drupal 7; there is a need of further tweaking. This is the main theme code

function theme_freeway_dashboard($variables) {
  $form = $variables['form'];
  drupal_add_js(drupal_get_path('module', 'freeway') . '/js/dashboardscript.js');
  global $user;
  $rows = array();
  foreach (element_children($form) as $key) {
    $row = array();
    if (isset($form[$key]['projectID'])) {
      $status = drupal_render($form['featured'][$key]);
      $row[] = array('data' => l(drupal_render($form[$key]['projectID']), 'user/' . $user->uid . '/freewayDashboardDetails', array('query' => array('project_id' => $form[$key]['projectID']['#value']))));

      $row[] = array('data' => drupal_render($form[$key]['projectDesc']));
      $row[] = array('data' => drupal_render($form[$key]['projectStatusCode']));

      $rows[] = $row;

      l(t('Title'), $url, array('attributes' => array('target' => '_blank')));
    }

  }

  $header = array();
  $header[] = t('Project ID');
  $header[] = t('Project Description');
  $header[] = t('Project Status');

  $output = '<div class="table_overflow">' . theme('table', array('header' => $header, 'rows' => $rows, 'attributes' => array('size' => 10, 'class' => array('table_class')))) . '</div>';

  


  $output .= drupal_render_children($form);


  return $output;


}

When i used Firebug on Drupal 7,the line of code using the link l() above is being seen code results in this.
The empty td and the link text for the href are resulting in a blank table :(

<td>
<a href="/drupal7cms/user/1/freewayDashboardDetails?project_id=438344">  </a>
</td>
<td></td>
<td></td>

I am trying to investigate why Drupal 7 fires blanks at these areas where Drupal 6 prints out the values required.
I have stareted refering your link

But would like to have your inputs as to what more needs to be done in Drupal 7.

Thanks

jaypan’s picture

jaypan
Location Victoria, BC
commented

It looks like you are rendering the incorrect form elements, and since they are empty, you are ending up with an empty table.

Do this at the top of your theme function:

debug($variables, '$variables', TRUE);

This will dump the $variables element to the screen, so you can see where the data is located. This should show you where you are going wrong in your theme function.

Contact me to contract me for D7 -> D10/11 migrations.
Or anything really. I'm friendly, and open to work or conversation.

angela.simmons’s picture

angela.simmons commented

I tried the debug and found this output for the first two project ID's that got print

Array
(
    [form] => Array
        (
            [#form_id] => freeway_dashboard
            [#type] => form
            [#build_id] => form-71DfgQz6QdeW0f-Vg_1W5VBNb1g5dd71MDMFsQrscX8
            [#token] => freeway_dashboard
            [#id] => freeway-dashboard
            [#method] => post
            [#action] => /drupal7cms/user/1/freewayDashboard
            [#theme_wrappers] => Array
                (
                    [0] => form
                    [1] => block
                )

            [#tree] => 
            [#parents] => Array
                (
                )

            [#validate] => Array
                (
                )

            [#submit] => Array
                (
                )

            [#theme] => Array
                (
                    [0] => freeway_dashboard
                )

            [#processed] => 
            [#defaults_loaded] => 1
            [#required] => 
            [#attributes] => Array
                (
                )

            [#title_display] => before
            [#array_parents] => Array
                (
                )

            [#block] => stdClass Object
                (
                    [bid] => 37
                    [module] => system
                    [delta] => main
                    [theme] => danland
                    [status] => 1
                    [weight] => 0
                    [region] => content
                    [custom] => 0
                    [visibility] => 0
                    [pages] => 
                    [title] => 
                    [cache] => -1
                    [i18n_mode] => 0
                    [subject] => 
                )

            [#weight] => 1
            [status_list] => Array
                (
                    [#type] => select
                    [#title] => Freeway Project Statuses
                    [#options] => Array
                        (
                            [0] => -Select Status-
                            [1] => Draft
                            [2] => NotSpecified
                            [3] => Quote
                            [4] => Forecasted
                            [5] => InEvaluation
                            [6] => Cancelled
                            [7] => Booked
                            [8] => InProduction
                            [9] => Completed
                            [10] => Closed
                        )

                    [#default_value] => Array
                        (
                            [0] => Select Status
                        )

                    [#weight] => 0
                    [#input] => 1
                    [#multiple] => 
                    [#process] => Array
                        (
                            [0] => form_process_select
                            [1] => ajax_process_form
                        )

                    [#theme] => select
                    [#theme_wrappers] => Array
                        (
                            [0] => form_element
                        )

                    [#defaults_loaded] => 1
                    [#tree] => 
                    [#parents] => Array
                        (
                            [0] => status_list
                        )

                    [#array_parents] => Array
                        (
                            [0] => status_list
                        )

                    [#processed] => 1
                    [#required] => 
                    [#attributes] => Array
                        (
                        )

                    [#title_display] => before
                    [#id] => edit-status-list
                    [#name] => status_list
                    [#value] => Array
                        (
                            [0] => Select Status
                        )

                    [#ajax_processed] => 
                    [#sorted] => 1
                )

            [438344] => Array
                (
                    [projectID] => Array
                        (
                            [#value] => 438344
                            [#tree] => 
                            [#parents] => Array
                                (
                                    [0] => projectID
                                )

                            [#array_parents] => Array
                                (
                                    [0] => 438344
                                    [1] => projectID
                                )

                            [#weight] => 0
                            [#processed] => 
                            [#required] => 
                            [#attributes] => Array
                                (
                                )

                            [#title_display] => before
                            [#id] => edit-projectid
                            [#sorted] => 1
                        )

                    [projectDesc] => Array
                        (
                            [#value] => Testin7
                            [#tree] => 
                            [#parents] => Array
                                (
                                    [0] => projectDesc
                                )

                            [#array_parents] => Array
                                (
                                    [0] => 438344
                                    [1] => projectDesc
                                )

                            [#weight] => 0.001
                            [#processed] => 
                            [#required] => 
                            [#attributes] => Array
                                (
                                )

                            [#title_display] => before
                            [#id] => edit-projectdesc
                            [#sorted] => 1
                        )

                    [projectStatusCode] => Array
                        (
                            [#value] => Draft
                            [#tree] => 
                            [#parents] => Array
                                (
                                    [0] => projectStatusCode
                                )

                            [#array_parents] => Array
                                (
                                    [0] => 438344
                                    [1] => projectStatusCode
                                )

                            [#weight] => 0.002
                            [#processed] => 
                            [#required] => 
                            [#attributes] => Array
                                (
                                )

                            [#title_display] => before
                            [#id] => edit-projectstatuscode
                            [#sorted] => 1
                        )

                    [#tree] => 
                    [#parents] => Array
                        (
                            [0] => 438344
                        )

                    [#array_parents] => Array
                        (
                            [0] => 438344
                        )

                    [#weight] => 0.001
                    [#processed] => 
                    [#required] => 
                    [#attributes] => Array
                        (
                        )

                    [#title_display] => before
                    [#id] => edit-438344
                    [#sorted] => 1
                )

            [438327] => Array
                (
                    [projectID] => Array
                        (
                            [#value] => 438327
                            [#tree] => 
                            [#parents] => Array
                                (
                                    [0] => projectID
                                )

                            [#array_parents] => Array
                                (
                                    [0] => 438327
                                    [1] => projectID
                                )

                            [#weight] => 0
                            [#processed] => 
                            [#required] => 
                            [#attributes] => Array
                                (
                                )

                            [#title_display] => before
                            [#id] => edit-projectid--2
                            [#sorted] => 1
                        )

                    [projectDesc] => Array
                        (
                            [#value] => Test Project
                            [#tree] => 
                            [#parents] => Array
                                (
                                    [0] => projectDesc
                                )

                            [#array_parents] => Array
                                (
                                    [0] => 438327
                                    [1] => projectDesc
                                )

                            [#weight] => 0.001
                            [#processed] => 
                            [#required] => 
                            [#attributes] => Array
                                (
                                )

                            [#title_display] => before
                            [#id] => edit-projectdesc--2
                            [#sorted] => 1
                        )

                    [projectStatusCode] => Array
                        (
                            [#value] => Draft
                            [#tree] => 
                            [#parents] => Array
                                (
                                    [0] => projectStatusCode
                                )

                            [#array_parents] => Array
                                (
                                    [0] => 438327
                                    [1] => projectStatusCode
                                )

                            [#weight] => 0.002
                            [#processed] => 
                            [#required] => 
                            [#attributes] => Array
                                (
                                )

                            [#title_display] => before
                            [#id] => edit-projectstatuscode--2
                            [#sorted] => 1
                        )

                    [#tree] => 
                    [#parents] => Array
                        (
                            [0] => 438327
                        )

                    [#array_parents] => Array
                        (
                            [0] => 438327
                        )

                    [#weight] => 0.002
                    [#processed] => 
                    [#required] => 
                    [#attributes] => Array
                        (
                        )

                    [#title_display] => before
                    [#id] => edit-438327
                    [#sorted] => 1
                )

I tried with the following code hoping for some success appending the ['#value'] for the row elements to be displayed.But still no output.

$row[] = array('data' => l(drupal_render($form[$key]['projectID']), 'user/' . $user->uid . '/freewayDashboardDetails', array('query' => array('project_id' => $form[$key]['projectID']['#value']))));

      $row[] = array('data' => drupal_render($form[$key]['projectDesc']['#value']));
      $row[] = array('data' => drupal_render($form[$key]['projectStatusCode']['#value']));

Jay was that a valid attempt from the observation in the debug?

Thanks
Angela

jaypan’s picture

jaypan
Location Victoria, BC
commented

In the form definition (which you haven't shown), it appears that you is no #type for some (or all - I didn't check) of the elements you are trying to render in the theme function. As such, Drupal has nothing to render, since it doesn't know what it's looking at.

This says to me that you are doing one of two things. The first is that you are purposefully not setting the #type, with the expectation that the value you set in #value will be printed to the screen. If this is the case, then you need to change #value (D6) to #markup (D7). The other possibility is that you have forgotten to set the #type, and in this case you will need to add the #type to the elements in the form definition.

Edit: You shouldn't be calling drupal_render on the #value of the form element, drupal_render() is meant to render entire form elements.

Contact me to contract me for D7 -> D10/11 migrations.
Or anything really. I'm friendly, and open to work or conversation.

angela.simmons’s picture

angela.simmons commented

Yes Jay, i think i am NOT using the 'type'. The following is the form. The only types i am using is the select etc.

function freeway_dashboard($form, &$form_state) {

  //1. Obtain credentials from credentialProvider();
  $arrayForSendTranslation = array();
  $arrayForSendTranslation = credentialProvider();
  $finalFunctionUserName = $arrayForSendTranslation[0];
  $finalFunctionPassword = $arrayForSendTranslation[1];

  //2. Add javascript file
  drupal_add_js(drupal_get_path('module', 'freeway') . '/js/dashboardscript.js');

  $listOfProjectsIds = array();
  $listOfProjectsDesc = array();
  $listOfProjectsStatusCode = array();
  $node = node_load(arg(1));
  $form = array();
  $url_arg = trim($_GET['status']);


  $LoginClient = new SoapClient("https://freeway?wsdl", array("trace" => 1));
  $ServicesLink = new SoapClient("https://freeway?wsdl", array("trace" => 1));

  if (!$url_arg) {
    try {


      $arrResponse = $LoginClient->Logon(array('Username' => $finalFunctionUserName, 'Password' => $finalFunctionPassword));

      $ticket = ($arrResponse->LogonResult);
      $getSrcLang = $ServicesLink->GetSourceLanguages(array('Ticket' => $ticket));
      $getDraftProjectIds = $ServicesLink->GetProjectSummariesList(array('Ticket' => $ticket, 'NumberOfProjects' => 100, 'SortOrder' => MostRecent, 'ProjectStatusCode' => 'Draft'));

      foreach ($getDraftProjectIds->GetProjectSummariesListResult->ProjectSummaries->ProjectSummary as $i => $getDraftProjectIds->GetProjectSummariesListResult->ProjectSummaries->ProjectSummary) {

        $listOfProjectsIds[$i] = $getDraftProjectIds->GetProjectSummariesListResult->ProjectSummaries->ProjectSummary->ID;
        $listOfProjectsDesc[$i] = $getDraftProjectIds->GetProjectSummariesListResult->ProjectSummaries->ProjectSummary->Description;
        $listOfProjectsStatusCode[$i] = $getDraftProjectIds->GetProjectSummariesListResult->ProjectSummaries->ProjectSummary->ProjectStatusCode;

      }


    }
    catch (SoapFault $exception) {
      drupal_get_messages();

      drupal_set_message("The following exception took place.");
      drupal_set_message("" . $exception . "");
      drupal_set_message("Kindly check Freeway mapping");

      drupal_goto("user");

    }
  }

  else {
    try {

      $arrResponse = $LoginClient->Logon(array('Username' => $finalFunctionUserName, 'Password' => $finalFunctionPassword));
      $ticket = ($arrResponse->LogonResult);
      $getSrcLang = $ServicesLink->GetSourceLanguages(array('Ticket' => $ticket));
      $getDraftProjectIds = $ServicesLink->GetProjectSummariesList(array('Ticket' => $ticket, 'NumberOfProjects' => 100, 'SortOrder' => MostRecent, 'ProjectStatusCode' => $url_arg));

      foreach ($getDraftProjectIds->GetProjectSummariesListResult->ProjectSummaries->ProjectSummary as $i => $getDraftProjectIds->GetProjectSummariesListResult->ProjectSummaries->ProjectSummary) {

        $listOfProjectsIds[$i] = $getDraftProjectIds->GetProjectSummariesListResult->ProjectSummaries->ProjectSummary->ID;
        $listOfProjectsDesc[$i] = $getDraftProjectIds->GetProjectSummariesListResult->ProjectSummaries->ProjectSummary->Description;
        $listOfProjectsStatusCode[$i] = $getDraftProjectIds->GetProjectSummariesListResult->ProjectSummaries->ProjectSummary->ProjectStatusCode;


      }

    }
    catch (SoapFault $exception) {
      drupal_get_messages();
      drupal_set_message("The following exception took place." . $exception . "Kindly check Freeway mapping");
      drupal_goto("user");


    }
  }

  $form['status_list'] = array(
    '#type' => 'select',
    '#title' => t('Freeway Project Statuses'),
    '#options' => array(
      0 => t('-Select Status-'),
      1 => t('Draft'),
      2 => t('NotSpecified'),
      3 => t('Quote'),
      4 => t('Forecasted'),
      5 => t('InEvaluation'),
      6 => t('Cancelled'),
      7 => t('Booked'),
      8 => t('InProduction'),
      9 => t('Completed'),
      10 => t('Closed'),
    ),
    '#default_value' => array('0' => 'Select Status'),
   // '#attributes' => array('onselect' => "populateStatusTables();"),
    '#weight' => 0,
  );



  for ($m = 0; $m < count($listOfProjectsIds); $m += 1) {
    $options[$listOfProjectsIds[$m]] = '';
    $form[$listOfProjectsIds[$m]]['projectID'] = array('#value' => $listOfProjectsIds[$m]);
    $form[$listOfProjectsIds[$m]]['projectDesc'] = array('#value' => $listOfProjectsDesc[$m]);
    $form[$listOfProjectsIds[$m]]['projectStatusCode'] = array('#value' => $listOfProjectsStatusCode[$m]);
  }




  return $form;

}
angela.simmons’s picture

angela.simmons commented

Jay should the markup in place of values substitution be done inside the form or the theme ? I think we are close to the resolution would like to have your support :).(It is been quite a struggle with the D6 to D7 transition)

Thanks
Angela

jaypan’s picture

jaypan
Location Victoria, BC
commented

Change this:

  $form[$listOfProjectsIds[$m]]['projectID'] = array('#value' => $listOfProjectsIds[$m]);
    $form[$listOfProjectsIds[$m]]['projectDesc'] = array('#value' => $listOfProjectsDesc[$m]);
    $form[$listOfProjectsIds[$m]]['projectStatusCode'] = array('#value' => $listOfProjectsStatusCode[$m]);

To this:

  $form[$listOfProjectsIds[$m]]['projectID'] = array('#markup' => $listOfProjectsIds[$m]);
    $form[$listOfProjectsIds[$m]]['projectDesc'] = array('#markup' => $listOfProjectsDesc[$m]);
    $form[$listOfProjectsIds[$m]]['projectStatusCode'] = array('#markup' => $listOfProjectsStatusCode[$m]);

Contact me to contract me for D7 -> D10/11 migrations.
Or anything really. I'm friendly, and open to work or conversation.

angela.simmons’s picture

angela.simmons commented

Jay ..thank you sooo much. This was the required change!
Cheers

jaypan’s picture

jaypan
Location Victoria, BC
commented

Glad to have helped!

Contact me to contract me for D7 -> D10/11 migrations.
Or anything really. I'm friendly, and open to work or conversation.