Need (better) import handler for CCK checkboxes

Ok, I have been seeing good results with the following import handler:

function _sf_node_import_cck_checkbox(&$node, $drupal_fieldname, $drupal_field_definition, $sf_data, $sf_fieldname, $sf_field_definition) {
  $content_field = content_fields($drupal_fieldname);
  $allowed_values = content_allowed_values($content_field);
  $off_key = key($allowed_values);
  array_shift($allowed_values);
  $on_key = key($allowed_values);
  $status = &$node->$drupal_fieldname;
  if ($sf_data->$sf_fieldname === FALSE) {
    $status[0]['value'] = $off_key;
  }
  elseif ($sf_data->$sf_fieldname === TRUE) {
    $status[0]['value'] = $on_key;
  }
  // Just in case, have a catch-all.
  else {
    $status[0]['value'] = $sf_data->$sf_fieldname;
  }
}

Which I'm enabling (for CCK fields that use the "optionwidgets_onoff" widget) in a custom module with hook_fieldmap_objects_alter:

function module_fieldmap_objects_alter(&$objects) {
  if (function_exists('_sf_node_import_cck_checkbox') && module_exists('content')) {
    foreach (content_types() as $type) {
      foreach ((array) $type['fields'] as $field) {
        if ($field['widget']['type'] == 'optionwidgets_onoff' && isset($objects['drupal']['node_' . $type['type']]['fields'][$field['field_name']]['import'])) {
          $objects['drupal']['node_' . $type['type']]['fields'][$field['field_name']]['import'] = '_sf_node_import_cck_checkbox';
        }
      }
    }
  }
}

If this import functionality is not already being managed elsewhere, perhaps a handler of this nature should be included in sf_node or sf_contrib? If so I could roll this as a patch.

Hi mtbosworth,

So you are using 0 and 1 as the keys in Drupal for a checkbox? Something like:

0|This is the off option
1|This is the on option

If so, I believe you have run into the same issue I noted in http://drupal.org/node/1195824#comment-5595962. Though that comment in issue #1195824 relates to exporting, the same on/off value calculations are used in the code I posed above. When commenting on #1195824 I also adjusted my test code for this import logic, but didn't post the change back to this thread.

So, to make a long story short, you might just want to replace the first chunk of code above with:

function _sf_node_import_cck_checkbox(&$node, $drupal_fieldname, $drupal_field_definition, $sf_data, $sf_fieldname, $sf_field_definition) {
  $content_field = content_fields($drupal_fieldname);
  $allowed_values = content_allowed_values($content_field);
  $off_key = key($allowed_values);
  next($allowed_values);
  $on_key = key($allowed_values);
  $status = &$node->$drupal_fieldname;
  if ($sf_data->$sf_fieldname === FALSE) {
    $status[0]['value'] = $off_key;
  }
  elseif ($sf_data->$sf_fieldname === TRUE) {
    $status[0]['value'] = $on_key;
  }
  // Just in case, have a catch-all.
  else {
    $status[0]['value'] = $sf_data->$sf_fieldname;
  }
}

The only change is that the line:
array_shift($allowed_values);
became:
next($allowed_values);

Hope that helps a bit.... let me know if you have any luck.

Also, given that you are using an integer datatype for checkboxes I wonder if the CCK field still uses the 'optionwidgets_onoff' widget type. If not, my code example won't detect that case and won't set _sf_node_import_cck_checkbox as the import handler. I'd be curious to know if you are able to confirm this with a bit of testing. Maybe throw a $dpm($objects); check at the end of function module_fieldmap_objects_alter(&$objects) and see if the import handler is infact set as _sf_node_import_cck_checkbox for your checkboxes?

Should this better be labeled as a feature request? I just wanted to inquire about why it was closed.

Got it. I noted in the initial message that I'd be willing to roll this as a patch, but given that this code can also easily be deployed in a custom (case-specific) module as an implementation of hook_fieldmap_objects_alter let's just leave it as-is. Hopefully the notes here will help someone who may need this. I'm just hoping/assuming this is not an issue in the new 7.x-3.x branch.