This might be a personal preference, but I think it should be a general solution.

Problem

When there is an error in the CTools modal, I believe the modal should scroll back to the top, so the error message is visible to users.

Other Info

What's weird though, is that on a form submit, the modal will jump a slight amount (20px) up the page. If the intended behaviour is to scroll to the top, then this is a bug report for Chrome. :)

Thanks!

CommentFileSizeAuthor
#1 ctools-modal-scroll-1439312-1.patch592 bytesDavid_Rothstein

Comments

David_Rothstein’s picture

David_Rothstein commented
Status: Active » Needs review
StatusFileSize
new ctools-modal-scroll-1439312-1.patch592 bytes

Here's a patch that seems to work.

It actually has the effect of always scrolling to the top on a new page load inside the modal (not just when there are form errors), but I think that makes sense, given that's what web browsers normally do.

merlinofchaos’s picture

merlinofchaos commented
Status: Needs review » Fixed

This has bugged me for a long time, but I was never sure of the proper fix. Committed and pushed! Thanks!

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

Anonymous’s picture

(not verified) commented
Issue summary: View changes

typos