We currently don't have any useful variables in _base.scss.

It would be handy to at least have:

  • font stack
  • base font size and base line height
  • link colors

Additional suggestions welcome.

CommentFileSizeAuthor
#1 1439712-1-more-variables.patch6.66 KBjohnalbin

Comments

johnalbin’s picture

johnalbin
they/他
Primary language English
Location Taipei, Taiwan
commented
Status: Active » Needs work
StatusFileSize
new 1439712-1-more-variables.patch6.66 KB

Work-in-progress patch

johnalbin’s picture

johnalbin
they/他
Primary language English
Location Taipei, Taiwan
commented
Status: Needs work » Postponed

I've committed part of this patch. http://drupalcode.org/project/zen.git/commitdiff/d1b5000

The rest should wait until after this issue is completed: #1372040: Use normalize.css as a basis for a new and improved html-reset.css

johnalbin’s picture

johnalbin
they/他
Primary language English
Location Taipei, Taiwan
commented
Title: Add default variables for use in html-elements file » Add default variables for use in sass files
johnalbin’s picture

johnalbin
they/他
Primary language English
Location Taipei, Taiwan
commented
Status: Postponed » Needs work
johnalbin’s picture

johnalbin
they/他
Primary language English
Location Taipei, Taiwan
commented
Priority: Normal » Major
Issue tags: +7.x-5.0 blocker

Tagging

johnalbin’s picture

johnalbin
they/他
Primary language English
Location Taipei, Taiwan
commented
Status: Needs work » Closed (duplicate)

Actually, all the variables in the patch in #1 are already included. I didn't look at this closely enough on April 1, I guess.

johnalbin’s picture

johnalbin
they/他
Primary language English
Location Taipei, Taiwan
commented
Issue tags: -7.x-5.0 blocker

Removing tag