regex is too permissive

Aye but that patch is waaaaaay too little. My patch is PHP 5.3 anyone is welcome to convert down to 5.2.

I need comments. Because I'm a dumb maintainer.

I'm seeing these when installing an install profile, likely just needs an empty() check for when no paths are modal.

preg_match(): Empty regular expression ctools_automodal.module:53    [warning]
preg_match(): Empty regular expression ctools_automodal.module:53    [warning]
implode(): Invalid arguments passed ctools_automodal.module:42       [warning]

@catch Unrelated error or error that happens with either of the patches applied?

Just the latest patch.

Trying to fix the bugs reported by catch in #3

This will throw a fatal error on php < 5.3 because of the line:

$convert_to_regexp = function ($value) { return preg_replace('/%[^\/]*/', '[^/]+', $value); };.

Any possible work-arounds? See https://github.com/wojtha/ctools_automodal/issues/1.

Edit: @chx: Obviously you knew that it was php 5.3 because you mentioned it in your post. Sorry for not catching it. I think it is important to make it work in php 5.2 for the issues outlined in the github issue. I'll see if I can figure it out.

This update to #6 makes the patch work with php < 5.3.

Just FYI, the last bugfix release of 5.2 was two years ago. The last security update was 1.5 years ago. I know, I know. But, still.

re-roll of #8 attached. This makes 2 changes:

1) The not-modal regexp was too greedy when there were no paths in it (@^@)
2) Adds comments per #2

updated patch attached, applies properly against head and eliminates a notice.