Closed (fixed)
Project:
Views Load More
Version:
7.x-1.1
Component:
Code
Priority:
Normal
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
14 Feb 2012 at 12:34 UTC
Updated:
26 Jul 2013 at 01:22 UTC
Jump to comment: Most recent file
Comments
Comment #1
k.elizabeth commentedI am experiencing this exact same issue. I have Ajax enabled, but clicking 'Load More' works only the first click. Subsequent clicks and I am advanced to '?page=2' . Trying to wrap my head around why this may be happening...
{Edit} Updated with the dev version of the module and it seems to work fine now!
Comment #2
ericduran commentedYea, views made a change to how they handler the ajax request, we fix this on the dev version.
Comment #3
alan evans commentedHi, I know this issue has been fixed in the latest dev version, but I'm not hugely fond of that fix on 2 accounts:
I wouldn't reopen this issue for the time being, just a heads up that I'm recommending this class be changed back to 'views-processed' in views, which would mean reverting this fix when that happens.
If my issue on views is accepted, then you could go back to the previous non-regex handling for the -processed class. If my issue gets rejected, then the regex could be tightened a little, given that we know the format of the jQuery once ID (always ends with -processed):
/jquery-once-[0-9]+-processed/The 0-9 will always be non-zero so can use '+' : "jquery-once--processed" would not be valid for the jQuery once auto-generated ID. The IDs begin at 1 in fact.
If I have time, I'll also look into changing once() so that the auto-generated IDs are retrievable in some way. That's part of the issue here - we can't easily know the auto-generated ID, so have to use the regex to determine the most likely IDs (though, to be honest, the regex is unlikely to ever fail in this limited context).
Comment #4
ericduran commented@Alan Evans I don't think this is the correct issue in regards to that. There's another issue where I talk about the jquery once, and a better approach for the future. I just never implemented that.
Comment #6
dalguete commentedHey everyone,
I just suffered this problem in a project. I'm posting a patch that may help you overcome this, and hopefully will work in the future if the 'views-processed' class is brought back to live.
Comment #7
dalguete commentedReposting patch, as the previous one was made with Netbeans. For this I used
git diffdirectly. More general.Comment #8
havran commentedThis patch fix #1806422 too. Thanks!
-- edit
I try dev version now and this seems fix this problem too.
Comment #9
rooby commentedIf you have a new patch, change the status so the maintainer can see.
Comment #10
rooby commentedSeems as per #8 that that patch is not needed anymore anyway. Setting back.