WebformSubmissionsController::load() returns entities in incorrect order

I tried sorting by title, and it worked for me. Can you explain your scenario when it doesn't work?

-      $entities = entity_load($entity_type, array_keys($results[$entity_type]));
+      $options = $results[$entity_type];
+      $entities = entity_load($entity_type, array_keys($options));

This has only one effect if you entity controller is broken and doesn't respect the order of the loaded IDs. Which one is it?

Even if it is not properly documented, DrupalEntityControllerInterface::load() needs to return entities in the same order as passed in $ids. This is a bug in Webform Entity.

@Damien Tournoud, is it just the order that's important or should all keys be returned? What about duplicates? Meaning if I request loading items array(3, 2, -99, 2, 4) what should come back?

// Only loadable entities?
array(
  3 => (some entity)
  2 => (some entity)
  4 => (some entity)
);
// Everything?
array(
  3 => (some entity)
  2 => (some entity)
  -99 => NULL,
  4 => (some entity)
);
// Or should it be based off the last time an id is seen?
array(
  3 => (some entity)
  -99 => NULL,
  2 => (some entity)
  4 => (some entity)
);

Committed (2 years later) thanks!.