API page: http://api.drupal.org/api/drupal/modules%21field_ui%21field_ui.admin.inc...

Describe the problem you have found:

The @see entries point to the wrong function names. They should be I think field_ui_field_overview_form_submit()/validate() [missing 'field' in the names].

CommentFileSizeAuthor
#9 fix-see-entries-1441126-9-D7.patch959 byteshaza
#5 fix-see-entries-1441126-5.patch997 bytesdevin carlson
#2 1441126_Fixed_field_ui_field_overview_form.patch1.22 KBhaza

Comments

jhodgdon’s picture

jhodgdon
she/her
Primary language English
commented

http://api.drupal.org/api/drupal/modules!field_ui!field_ui.admin.inc/fun... needs the same fix, and could be combined with this issue.

haza’s picture

haza
Primary language French
commented
Status: Active » Needs review
StatusFileSize
new 1441126_Fixed_field_ui_field_overview_form.patch1.22 KB

And a little patch for that.

jhodgdon’s picture

jhodgdon
she/her
Primary language English
commented
Status: Needs review » Reviewed & tested by the community

Looks good, thanks!

jhodgdon’s picture

jhodgdon
she/her
Primary language English
commented
Status: Reviewed & tested by the community » Needs work

Uh oh, I just noticed - the @see lines should not end in ".". Those need to be removed.

devin carlson’s picture

devin carlson commented
Status: Needs work » Needs review
StatusFileSize
new fix-see-entries-1441126-5.patch997 bytes

The same changes as #2 but without the periods.

sven.lauer’s picture

sven.lauer commented
Status: Needs review » Reviewed & tested by the community

Looks good to me.

mottihoresh’s picture

mottihoresh commented

looks good

jhodgdon’s picture

jhodgdon
she/her
Primary language English
commented
Version: 8.x-dev » 7.x-dev
Status: Reviewed & tested by the community » Patch (to be ported)

Committed to 8.x. The patch doesn't apply to 7.x (even with -p2), so it needs a backport.

haza’s picture

haza
Primary language French
commented
Status: Patch (to be ported) » Needs review
StatusFileSize
new fix-see-entries-1441126-9-D7.patch959 bytes

D7 backport

jhodgdon’s picture

jhodgdon
she/her
Primary language English
commented
Status: Needs review » Fixed

Thanks! Committed to 7.x.

Automatically closed -- issue fixed for 2 weeks with no activity.