When both Fieldgroups and Title are enabled, the UI for Manage Fields becomes broken.

The Title module creates a new table cell for the "Replace" operation.
The module adds empty cells to the other rows that do not need a "Replace" operation.

But, the Fieldgroup row does not get an extra cell, causing UI issues.

CommentFileSizeAuthor
#3 field_group-title-ui_problem-1441224-3.diff1.13 KBmiroslavbanov
#3 column-problem.png28.98 KBmiroslavbanov
#1 empty_title.png35.73 KBsteinmb

Comments

steinmb’s picture

steinmb commented
Priority: Normal » Major
StatusFileSize
new empty_title.png35.73 KB

Prob. related to this also. The attached screenshot show an title field replaced for a taxonomy term.
Empty title string

Inspecting the term object show that the 'name' string is empty. I thought that we also need to update the title (name) when saving the enity not only the name_field text field it create? The terms listed under the empty term-name is terms created/edited before replacing the title.

plach’s picture

plach
he/him
Primary language Italian
Location Venezia
commented
Priority: Major » Normal

#1 is a different issue, please check whther there is already a bug report for it.

miroslavbanov’s picture

miroslavbanov commented
Issue summary: View changes
Status: Active » Needs review
StatusFileSize
new column-problem.png28.98 KB
new field_group-title-ui_problem-1441224-3.diff1.13 KB

This is a fix to the original issue where in the UI the html columns are broken - one less for field group related stuff. I've attached a patch to illustrate. Fixed by making the replace link take the column for delete operation, which I believe makes perfect sense.

hellolindsay’s picture

hellolindsay commented

I have this issue as well. Any chance we could get the patch in #3 added to the official release?

Stevel’s picture

Stevel commented
Status: Needs review » Reviewed & tested by the community

Yes, let's get this in. Patch looks good and fixes the issue, so RTBC.

plach’s picture

plach
he/him
Primary language Italian
Location Venezia
commented
Status: Reviewed & tested by the community » Fixed

Committed and pushed, thanks.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

  • Commit 4efbf57 on 7.x-1.x, workbench authored by MiroslavBanov, committed by plach: 
    Issue #1441224 by MiroslavBanov | OPIN: Fieldgroup and Title break...