Recent Conversion Failings

Since the day before yesterday a site we created also is having problems converting files. Actually the files do upload to the server and to scribd but a conversion error appears. As soon as I get to my laptop I'll post all the messages and things I tried. Untill this bug report, we tought we where the only ones with this problem.

same problem here; this is the error in the log:

Scribd error #: <?xml version="1.0" encoding="UTF-8"?><rsp stat="ok"><doc_id>81721380</doc_id><access_key>key-...</access_key><secret_password>...</secret_password></rsp>

and in the page: "The previous attempt to convert this document to an iPaper failed. Click here to retry"
on each retry the file is uploaded again (as a distinct file) on scribd; we ended with a lot of copies of each file on scribd

there's an error in scribd.php
the comparison operator should be '==='; otherwise, the comparison returns true even if $result is an object

240c240
< 		if($result == FALSE){
---
> 		if($result === FALSE){

this change seems to solve the upload problem; i don't know git so i can't prepare a proper patch right now; sorry

there's one more error reported with the change above; on $scribd->changeSettings call the result is empty, with only the attribute 'stat' set to 'ok'; that call should return "1", not the empty string (otherwise is interpreted as a failed call)

240c240
< 		if($result == FALSE){
---
> 		if($result === FALSE){
267a268
> 					if (!$result) return "1";

@murfi - THANKS that worked for me too.

murfi you're a lifesaver - site just went live at a fairly major launch and had to get another publication up yesterday only to hit this problem. Your fix worked a treat; much appreciated :)

Worked! :) Thanks!

murfi's changes worked for me. attached here as a patch (syntax slightly modified) that can be applied to both 5.x (what I've tested on) and 6.x branches.

FYI: the code in error came from a contributed library listed at http://www.scribd.com/developers/platform, and the latest download there appears unchanged.

Perfect! This is the fix. Thank you so much.

the patch work!

Any chance we can get this rolled into dev?

I had similar problems with ipaper version 6.x-1.1; downloaded to Scribd but to ipaper. The patch above worked except that it did not show the download. However, it did download the thumbnail to the correct file on the server requiring a manual upload of the thumbnail. When I requested help from Scribd, they wrote back

"Drupal incorporates an outdated version of our embedded reader which we no longer support. As such, there is not much more I can do to assist you beyond recommending our new HTML5 embed frame. My apologies for any inconvenience this may cause.

Best regards,
Gary Villalobos
Scribd, Inc. "

Ipaper with Scribd is a great module; I hope it is updated to reflect the changes made by Scribd in their embed reader.

Thank you Murfi and Rymo, solved it for me for D6