Subscribe using 'Direct operation' (single click) doesn't work properly

This is not specific to terms, it is all subscriptions.

1 click works for unsubscribe but not subscribe.

When subscribing I get the confirmation page still and this message:

This link is not valid anymore. Please get a new one or contact the site administrator.

I am having the same issue. Did anyone fix this issue?

I just made this change to Direct subscribe in my Notifications settings and encountered the same bug. It's been a year with no solution and not even a response from the maintainers. Does anyone know what's happening with this?

I see that this module is "Seeking new maintainer" and in a status of "Maintenance fixes only". However, I would think that this bug would qualify as a maintenance fix.

From a marketing or user experience perspective, depending on which is your priority, this bug is really a problem: Clicking on subscribe is all that most people are willing to do. Having to click a confirmation (especially one that isn't a modal dialog that forces you to do so) is going to frustrate many users; worse yet, after clicking on the subscribe button initially, many users are going to close the window or otherwise leave the page without clicking to confirm -- not even realizing they needed to perform a second action.

I don't know the exact percentages off the top of my head (although I know there's research on this), but doubling the amount of required clicks is going to increase frustration and decrease conversion by some really significant amount. And that will only get worse if the goal is to get the users to subscribe to a lot of posts. Effectively, adding the confirm screen is what you do when you are trying to either (1) "cover-your-ass" if the thing being confirmed is controversial or has legal ramifications (like the additional confirmation button on most Terms of Service agreement prompts -- that should actually require a signature, but don't, so at least Apple etc. can say, "hey, they clicked twice, so there's not doubt they were consenting") or (2) discourage users from the behavior -- like requiring confirmation to opt out of something. Making them do this for a simple subscription (1) unnecessary, as they can easily unsubscribe at any time and there are no further legal or logistical ramifications, and (2) worst of all, again, discouraging them from subscribing in the first place.

Is there anyone who has any ideas about how to fix this or get this fixed?

If you are willing to change to using the subscriptions module you could try this issue: #1451312: Simple one click subscribe/unsubscribe link

I haven't actually used the code in that issue though as I have customised my own version.

The problem turns out to be the ksort function on line 983. The indexes of the array are mixed string and integer which ksort doesn't handle well out of the box. See http://php.net/manual/en/function.ksort.php. Attaching a patch that fixes the issue for me.

This patch works for me.

Number #7 works for me too. Thanks!!!

Closed a duplicate: #1369360: notifications_array_serialize should use ksort with flag SORT_STRING

Thank you for the patch, randallknutson!